From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 4/4] drm/i915: set pm._irqs_disabled at IRQ
 init time
Date: Mon, 14 Jul 2014 13:25:01 -0700
Message-ID: <20140714132501.36f66088@jbarnes-desktop>
References: <1403281762-1927-1-git-send-email-jbarnes@virtuousgeek.org>
 <1403281762-1927-4-git-send-email-jbarnes@virtuousgeek.org>
 <CA+gsUGQC=0gKxkzD7BF0r2tDJsD71gNKojxR0poRofifqqaLGQ@mail.gmail.com>
 <20140714172633.GH15237@phenom.ffwll.local>
 <CA+gsUGSPc1eLhXZmsCdNe=ij9-x8ZA5_e-jAm-0L+TULbZdFHA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43])
 by gabe.freedesktop.org (Postfix) with ESMTP id 91CD789E43
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Jul 2014 13:23:59 -0700 (PDT)
Received: by mail-pa0-f43.google.com with SMTP id lf10so5594841pab.30
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Jul 2014 13:23:59 -0700 (PDT)
In-Reply-To: <CA+gsUGSPc1eLhXZmsCdNe=ij9-x8ZA5_e-jAm-0L+TULbZdFHA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 14 Jul 2014 14:47:07 -0300
Paulo Zanoni <przanoni@gmail.com> wrote:

> 2014-07-14 14:26 GMT-03:00 Daniel Vetter <daniel@ffwll.ch>:
> > On Mon, Jul 14, 2014 at 12:23:11PM -0300, Paulo Zanoni wrote:
> >> 2014-06-20 13:29 GMT-03:00 Jesse Barnes <jbarnes@virtuousgeek.org>:
> >> > Before we've installed the handler, we can set this and avoid confusing
> >> > init code that then thinks IRQs are enabled and spews complaints
> >> > everywhere.
> >>
> >> But then at some point the DRM layer will call our IRQ init callbacks,
> >> which will initalize the interrupts but leave irqs_disabled as true,
> >> which will also confuse some code somewhere at some point. And it will
> >> only be set to false after we {runtime,}-suspend/resume.
> >
> > The drm irq stuff is _strictly_ a helper library, at least for modesetting
> > drivers. Which means it will never call our callbacks on its own.
> 
> I was talking about drm_irq_install(), which is called by i915_driver_load().

Since this set fixes the failures I've found, I'd rather see it merged
than to regress everyone's power consumption.

I think it'll probably take us awhile to figure out how we want to do
this stuff.  Paulo, maybe you can create a task with some of the things
you'd like to see done?

With these patches, we go away from ever using the drm irq bits except
for at load and unload.  We use the pm irq fields for tracking our own
stuff, which means some special init handling and then calls at
suspend/resume, so I don't think it's too complex as-is, but if you
want to do something better, that's ok too.

-- 
Jesse Barnes, Intel Open Source Technology Center