From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6
Date: Mon, 14 Jul 2014 19:27:02 +0200
Message-ID: <20140714172702.GI15237@phenom.ffwll.local>
References: <1403934986-3820-1-git-send-email-deepak.s@linux.intel.com>
 <53C4D963.8060101@linux.intel.com>
 <20140714081715.532fbe97@jbarnes-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6F4826E13D
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Jul 2014 10:26:51 -0700 (PDT)
Received: by mail-wg0-f44.google.com with SMTP id m15so4395532wgh.27
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Jul 2014 10:26:50 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140714081715.532fbe97@jbarnes-desktop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jul 14, 2014 at 08:17:15AM -0700, Jesse Barnes wrote:
> On Tue, 15 Jul 2014 13:03:55 +0530
> Deepak S <deepak.s@linux.intel.com> wrote:
> 
> > 
> > On Saturday 28 June 2014 11:26 AM, deepak.s@linux.intel.com wrote:
> > > From: Deepak S <deepak.s@linux.intel.com>
> > >
> > > Drop WaGsvBringDownFreq on CHV.
> > > When in RC6 requesting the min freq should be fine to bring the
> > > voltage down.
> > >
> > > Signed-off-by: Deepak S <deepak.s@linux.intel.com>
> > > ---
> > >   drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> > >   1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > > index 6b6cfd4..4875f745 100644
> > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > @@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
> > >   
> > >   	mutex_lock(&dev_priv->rps.hw_lock);
> > >   	if (dev_priv->rps.enabled) {
> > > -		if (IS_VALLEYVIEW(dev))
> > > +		if (IS_CHERRYVIEW(dev))
> > > +			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> > > +		else if (IS_VALLEYVIEW(dev))
> > >   			vlv_set_rps_idle(dev_priv);
> > >   		else
> > >   			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
> > 
> > Hi Jesse,
> > 
> > can you please review this patch?
> 
> Reviewed-by: Jesse Barnes <jbarnes@Virtuousgeek.org>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch