public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Todd Previte <tprevite@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 11/12] drm/i915: Minor code clean up in intel_dp.c
Date: Tue, 15 Jul 2014 09:47:22 +0200	[thread overview]
Message-ID: <20140715074722.GP15237@phenom.ffwll.local> (raw)
In-Reply-To: <1405365047-6866-12-git-send-email-tprevite@gmail.com>

On Mon, Jul 14, 2014 at 12:10:46PM -0700, Todd Previte wrote:
> Cleans up a couple of unused variables and an extraneous debug log
> message that was unintentionally left behind.
> 
> Signed-off-by: Todd Previte <tprevite@gmail.com>

This should be squashed into the relevant earlier patches.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index e4b31ad..0e207aaf 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -3430,7 +3430,6 @@ intel_dp_autotest_link_training(struct intel_dp *intel_dp)
>  	uint8_t rxdata[2];
>  	uint8_t link_status[DP_LINK_STATUS_SIZE];
>  	int bytes_ret = 0;
> -	struct drm_connector *connector = &intel_dp->attached_connector->base;
>  	struct intel_digital_port *intel_dig_port =
>  		enc_to_dig_port(&intel_dp->attached_connector->encoder->base);
>  
> @@ -3494,7 +3493,7 @@ intel_dp_autotest_edid(struct intel_dp *intel_dp)
>  	struct edid *edid_read = NULL;
>  	uint8_t *edid_data = NULL;
>  	uint8_t test_result = DP_TEST_NAK, checksum = 0;
> -	uint32_t i = 0, ret = 0;
> +	uint32_t ret = 0;
>  	struct drm_display_mode *use_mode = NULL;
>  	int mode_count = 0;
>  	struct drm_mode_set modeset;
> @@ -3592,7 +3591,6 @@ intel_dp_handle_test_request(struct intel_dp *intel_dp)
>  	uint8_t rxdata = 0;
>  	int ret = 0;
>  
> -	DRM_DEBUG_KMS("Displayport: Received automated test request\n");
>  	/* Read DP_TEST_REQUEST register to identify the requested test */
>  	ret = drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_REQUEST, &rxdata, 1);
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-07-15  7:47 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 19:10 [PATCH v2] Displayport compliance testing Todd Previte
2014-07-14 19:10 ` [PATCH 01/12] drm/i915: Add automated testing support for " Todd Previte
2014-07-21 22:09   ` Paulo Zanoni
2014-07-30 14:49   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 02/12] drm/i915: Add a function to compute the EDID checksum for Displayport compliance Todd Previte
2014-07-21 22:28   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 03/12] drm/i915: Add counters in the drm_dp_aux struct for I2C NACKs and DEFERs Todd Previte
2014-07-21 22:37   ` Paulo Zanoni
2014-11-04 22:17     ` [PATCH 02/10] " Todd Previte
2014-11-04 22:26       ` Daniel Vetter
2014-07-14 19:10 ` [PATCH 04/12] drm/i915: Add wrapper function for intel_crtc_set_config() Todd Previte
2014-07-21 23:34   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 05/12] drm/i915: Add a function to get the EDID preferred mode for Displayport compliance testing Todd Previte
2014-07-21 23:41   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 06/12] drm/i915: Add a constant and function for getting the Displayport compliance failsafe video mode Todd Previte
2014-07-21 23:42   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 07/12] drm/i915: Update EDID automated test function for Displayport compliance Todd Previte
2014-07-29 22:37   ` Paulo Zanoni
2014-07-31 18:27     ` Todd Previte
2014-07-14 19:10 ` [PATCH 08/12] drm/i915: Improve reliability for Displayport link training Todd Previte
2014-07-30 14:07   ` Paulo Zanoni
2014-07-30 15:25     ` Daniel Vetter
2014-07-14 19:10 ` [PATCH 09/12] drm/i915: Update intel_dp_check_link_status() for Displayport compliance testing Todd Previte
2014-07-30 14:29   ` Paulo Zanoni
2014-07-14 19:10 ` [PATCH 10/12] drm/i915: Update link training automated test function for Displayport compliance Todd Previte
2014-07-22  6:15   ` Daniel Vetter
2014-07-22 20:40     ` Jesse Barnes
2014-07-22 20:44       ` Daniel Vetter
2014-07-22 21:03         ` Jesse Barnes
2014-07-14 19:10 ` [PATCH 11/12] drm/i915: Minor code clean up in intel_dp.c Todd Previte
2014-07-15  7:47   ` Daniel Vetter [this message]
2014-07-15 15:35     ` Todd Previte
2014-07-14 19:10 ` [PATCH 12/12] drm/i915: Add a delay in Displayport AUX transactions for compliance testing Todd Previte
2014-07-15  7:46   ` Daniel Vetter
2014-07-15 15:34     ` Todd Previte
2014-07-30 14:46       ` Paulo Zanoni
2014-07-22  6:41 ` [PATCH v2] Displayport " Daniel Vetter
2014-07-22 20:48   ` Jesse Barnes
2014-07-22 20:53     ` Daniel Vetter
2014-07-22 21:11       ` Jesse Barnes
2014-07-29 21:53         ` Paulo Zanoni
2014-07-30  9:31           ` Daniel Vetter
2014-07-31 18:27           ` Todd Previte
2014-07-22 20:57     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715074722.GP15237@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tprevite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox