public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: deepak.s@linux.intel.com
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix printing proper min/min/rpe values in debugfs
Date: Thu, 17 Jul 2014 10:42:20 +0200	[thread overview]
Message-ID: <20140717084220.GE15237@phenom.ffwll.local> (raw)
In-Reply-To: <1405587074-22887-1-git-send-email-deepak.s@linux.intel.com>

On Thu, Jul 17, 2014 at 02:21:14PM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@linux.intel.com>
> 
> This was fumbled while trying to use the cached min/min/rpe values in
> the vlv debugfs code.
> 
>     This is a regression from
> 
>     commit 03af20458a57a50735b12c1e3c23abc7ff70c6fa
>     Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
>     Date:   Sat Jun 28 02:03:53 2014 +0300
> 
>     drm/i915: Use the cached min/min/rpe values in the vlv debugfs code
> 
> Signed-off-by: Deepak S <deepak.s@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index fc39610..5bc65af 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1116,13 +1116,13 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
>  		seq_printf(m, "DDR freq: %d MHz\n", dev_priv->mem_freq);
>  
>  		seq_printf(m, "max GPU freq: %d MHz\n",
> -			   dev_priv->rps.max_freq);
> +			   vlv_gpu_freq(dev_priv, dev_priv->rps.max_freq));
>  
>  		seq_printf(m, "min GPU freq: %d MHz\n",
> -			   dev_priv->rps.min_freq);
> +			   vlv_gpu_freq(dev_priv, dev_priv->rps.min_freq));
>  
>  		seq_printf(m, "efficient (RPe) frequency: %d MHz\n",
> -			   dev_priv->rps.efficient_freq);
> +			   vlv_gpu_freq(dev_priv, dev_priv->rps.efficient_freq));
>  
>  		seq_printf(m, "current GPU freq: %d MHz\n",
>  			   vlv_gpu_freq(dev_priv, (freq_sts >> 8) & 0xff));
> -- 
> 1.9.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-07-17  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  8:51 [PATCH] drm/i915: Fix printing proper min/min/rpe values in debugfs deepak.s
2014-07-17  8:42 ` Daniel Vetter [this message]
     [not found]   ` <20140718024425.GB6673@bwidawsk.net>
2014-07-18  2:45     ` Ben Widawsky
  -- strict thread matches above, loose matches on Subject: below --
2014-07-17  8:31 deepak.s

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140717084220.GE15237@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=deepak.s@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox