From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 06/16] drm/i915/error: Check the potential ctx obj's vm Date: Thu, 17 Jul 2014 10:47:48 +0200 Message-ID: <20140717084748.GF15237@phenom.ffwll.local> References: <1404238671-18760-1-git-send-email-benjamin.widawsky@intel.com> <1404238671-18760-7-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 51A676E04A for ; Thu, 17 Jul 2014 01:47:44 -0700 (PDT) Received: by mail-we0-f170.google.com with SMTP id w62so2106069wes.29 for ; Thu, 17 Jul 2014 01:47:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1404238671-18760-7-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 01, 2014 at 11:17:41AM -0700, Ben Widawsky wrote: > The bound list is global (all objects which back the VMAs are stored > here). Recently the BUG() in the offset lookup was demoted to a WARN, > but the fault actually lies in the caller, here. > > This bug has existed since the initial introduction of PPGTT (however, > it was fixed in unmerged patches to fix up the error state). Aside: This is another bug than the one which spurred me to demote the BUG_ON to a WARN_ON. Patch merged with that patch referenced for clarity. -Daniel > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 66cf417..550ba38 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -871,6 +871,9 @@ static void i915_gem_record_active_context(struct intel_engine_cs *ring, > return; > > list_for_each_entry(obj, &dev_priv->mm.bound_list, global_list) { > + if (!i915_gem_obj_ggtt_bound(obj)) > + continue; > + > if ((error->ccid & PAGE_MASK) == i915_gem_obj_ggtt_offset(obj)) { > ering->ctx = i915_error_ggtt_object_create(dev_priv, obj); > break; > -- > 2.0.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch