From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/8] drm/i915: Setting legacy palette correctly for different platforms Date: Mon, 21 Jul 2014 17:49:07 +0200 Message-ID: <20140721154907.GX15237@phenom.ffwll.local> References: <1405936425-17341-1-git-send-email-sonika.jindal@intel.com> <1405936425-17341-5-git-send-email-sonika.jindal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 891F2884FD for ; Mon, 21 Jul 2014 08:48:59 -0700 (PDT) Received: by mail-we0-f170.google.com with SMTP id w62so7812116wes.15 for ; Mon, 21 Jul 2014 08:48:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1405936425-17341-5-git-send-email-sonika.jindal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sonika.jindal@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jul 21, 2014 at 03:23:41PM +0530, sonika.jindal@intel.com wrote: > From: Sonika Jindal > > Signed-off-by: Sonika Jindal > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index c89b4ac..442d8ba 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -3847,7 +3847,7 @@ static void intel_crtc_load_lut(struct drm_crtc *crtc) > } > > /* use legacy palette for Ironlake */ > - if (HAS_PCH_SPLIT(dev)) > + if (INTEL_INFO(dev)->gen >= 5 && !IS_VALLEYVIEW(dev)) Imo we should check for !HAS_GMCH_DISPLAY here. -Daniel > palreg = LGC_PALETTE(pipe); > > /* Workaround : Do not read or write the pipe palette/gamma data while > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch