From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 7/8] drm/i915: Replace HAS_PCH_SPLIT which incorrectly lets some platforms in Date: Mon, 21 Jul 2014 17:51:39 +0200 Message-ID: <20140721155138.GZ15237@phenom.ffwll.local> References: <1405936425-17341-1-git-send-email-sonika.jindal@intel.com> <1405936425-17341-8-git-send-email-sonika.jindal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AE186E42B for ; Mon, 21 Jul 2014 08:51:32 -0700 (PDT) Received: by mail-we0-f169.google.com with SMTP id u56so7787763wes.0 for ; Mon, 21 Jul 2014 08:51:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1405936425-17341-8-git-send-email-sonika.jindal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sonika.jindal@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Jul 21, 2014 at 03:23:44PM +0530, sonika.jindal@intel.com wrote: > From: Sonika Jindal > > Signed-off-by: Sonika Jindal > --- > drivers/gpu/drm/i915/intel_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > index 5f8f4ca..458dd4f 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1562,7 +1562,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > if (IS_VALLEYVIEW(dev)) { > intel_hdmi->write_infoframe = vlv_write_infoframe; > intel_hdmi->set_infoframes = vlv_set_infoframes; > - } else if (!HAS_PCH_SPLIT(dev)) { > + } else if (INTEL_INFO(dev)->gen < 5) { Maybe make this explicit and check for IS_G4X(dev) instead? It's the only platform where this case applies, and also nicely highlights how the g4x_ prefix of the functions matches. -Daniel > intel_hdmi->write_infoframe = g4x_write_infoframe; > intel_hdmi->set_infoframes = g4x_set_infoframes; > } else if (HAS_DDI(dev)) { > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch