Re: [PATCH i-g-t 2/8] tests: remove unused getopt header includes

Gore, Tim
2014-07-24T09:52:02Z

Looks fine to me.

> -----Original Message-----
> From: Thomas Wood [mailto:thomas.wood@intel.com]
> Sent: Wednesday, July 23, 2014 11:58 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Gore, Tim; daniel.vetter@ffwll.ch
> Subject: [PATCH i-g-t 2/8] tests: remove unused getopt header includes
>
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Reviewed-by: Tim Gore <tim.gore@intel.com>
> ---
> lib/drmtest.c | 1 -
> lib/igt_aux.c | 1 -
> lib/rendercopy_gen6.c | 1 -
> lib/rendercopy_gen7.c | 1 -
> lib/rendercopy_gen8.c | 1 -
> lib/rendercopy_i830.c | 1 -
> lib/rendercopy_i915.c | 1 -
> tests/gem_media_fill.c | 1 -
> tests/gem_render_copy_redux.c | 1 -
> tests/gem_render_linear_blits.c | 1 -
> tests/gem_render_tiled_blits.c | 1 -
> tests/gem_wait_render_timeout.c | 1 -
> tests/kms_setmode.c | 1 -
> tests/pm_rps.c | 1 -
> 14 files changed, 14 deletions(-)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c index 7be2e40..f921f67 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -39,7 +39,6 @@
> #include <sys/mman.h>
> #include <signal.h>
> #include <pciaccess.h>
> -#include <getopt.h>
> #include <stdlib.h>
> #include <unistd.h>
> #include <sys/wait.h>
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c index 7b277be..0bcaa3b 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -39,7 +39,6 @@
> #include <sys/mman.h>
> #include <signal.h>
> #include <pciaccess.h>
> -#include <getopt.h>
> #include <stdlib.h>
> #include <unistd.h>
> #include <sys/wait.h>
> diff --git a/lib/rendercopy_gen6.c b/lib/rendercopy_gen6.c index
> 7b3104c..afe7562 100644
> --- a/lib/rendercopy_gen6.c
> +++ b/lib/rendercopy_gen6.c
> @@ -9,7 +9,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
> #include "drm.h"
> #include "i915_drm.h"
> #include "drmtest.h"
> diff --git a/lib/rendercopy_gen7.c b/lib/rendercopy_gen7.c index
> 5131d8f..2932f1e 100644
> --- a/lib/rendercopy_gen7.c
> +++ b/lib/rendercopy_gen7.c
> @@ -9,7 +9,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
> #include "drm.h"
> #include "i915_drm.h"
> #include "drmtest.h"
> diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c index
> a32871d..ff0b0c8 100644
> --- a/lib/rendercopy_gen8.c
> +++ b/lib/rendercopy_gen8.c
> @@ -9,7 +9,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
>
> #include <drm.h>
> #include <i915_drm.h>
> diff --git a/lib/rendercopy_i830.c b/lib/rendercopy_i830.c index
> f0235a5..04215b1 100644
> --- a/lib/rendercopy_i830.c
> +++ b/lib/rendercopy_i830.c
> @@ -8,7 +8,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
> #include "drm.h"
> #include "i915_drm.h"
> #include "drmtest.h"
> diff --git a/lib/rendercopy_i915.c b/lib/rendercopy_i915.c index
> 1acf9da..fc9583c 100644
> --- a/lib/rendercopy_i915.c
> +++ b/lib/rendercopy_i915.c
> @@ -8,7 +8,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
> #include "drm.h"
> #include "i915_drm.h"
> #include "drmtest.h"
> diff --git a/tests/gem_media_fill.c b/tests/gem_media_fill.c index
> db2380b..b06a556 100644
> --- a/tests/gem_media_fill.c
> +++ b/tests/gem_media_fill.c
> @@ -41,7 +41,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
> #include "drm.h"
> #include "ioctl_wrappers.h"
> #include "drmtest.h"
> diff --git a/tests/gem_render_copy_redux.c
> b/tests/gem_render_copy_redux.c index f711fdb..cb48aa7 100644
> --- a/tests/gem_render_copy_redux.c
> +++ b/tests/gem_render_copy_redux.c
> @@ -43,7 +43,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
>
> #include <drm.h>
>
> diff --git a/tests/gem_render_linear_blits.c
> b/tests/gem_render_linear_blits.c index ee99dea..28fd8c8 100644
> --- a/tests/gem_render_linear_blits.c
> +++ b/tests/gem_render_linear_blits.c
> @@ -46,7 +46,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
>
> #include <drm.h>
>
> diff --git a/tests/gem_render_tiled_blits.c b/tests/gem_render_tiled_blits.c
> index 3d83f7c..ea1d59d 100644
> --- a/tests/gem_render_tiled_blits.c
> +++ b/tests/gem_render_tiled_blits.c
> @@ -42,7 +42,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
>
> #include <drm.h>
>
> diff --git a/tests/gem_wait_render_timeout.c
> b/tests/gem_wait_render_timeout.c index a34c006..3afab9c 100644
> --- a/tests/gem_wait_render_timeout.c
> +++ b/tests/gem_wait_render_timeout.c
> @@ -36,7 +36,6 @@
> #include <errno.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> -#include <getopt.h>
>
> #include <drm.h>
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index
> 0b765a9..8762255 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -29,7 +29,6 @@
> #include <stdint.h>
> #include <unistd.h>
> #include <string.h>
> -#include <getopt.h>
> #include <sys/time.h>
>
> #include "drmtest.h"
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c index c1156a5..96fec99 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -31,7 +31,6 @@
> #include <stdlib.h>
> #include <string.h>
> #include <unistd.h>
> -#include <getopt.h>
> #include <fcntl.h>
> #include <signal.h>
> #include <errno.h>
> --
> 1.9.3