From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: "Volkin, Bradley D" <bradley.d.volkin@intel.com>,
intel-gfx@lists.freedesktop.org,
Akash Goel <akash.goel@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Allow overlapping userptr objects
Date: Wed, 23 Jul 2014 16:34:22 +0200 [thread overview]
Message-ID: <20140723143422.GU15237@phenom.ffwll.local> (raw)
In-Reply-To: <53CFB769.8000704@linux.intel.com>
On Wed, Jul 23, 2014 at 02:23:53PM +0100, Tvrtko Ursulin wrote:
> Looks fine. Performance impact is potentially big as we discussed but I
> suppose we can leave that for later if an issue. So:
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Merged, thanks for patch and review.
> I think it would be good to add some more tests to cover the tracking
> "handover" between the interval tree and linear list to ensure invalidation
> still works correctly in non-trivial cases. Code looks correct in that
> respect but just in case. It is not a top priority so not sure when I'll
> find time to actually do it.
We don't yet have some tests with overlapping allocations? I think at
least some basic smoke test should be there ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-23 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 12:21 [PATCH 1/2] drm/i915: Allow overlapping userptr objects Chris Wilson
2014-07-21 12:21 ` [PATCH 2/2] drm/i915: Prevent recursive deadlock on releasing a busy userptr Chris Wilson
2014-07-21 19:48 ` Chris Wilson
2014-07-23 16:39 ` Tvrtko Ursulin
2014-07-23 17:15 ` Chris Wilson
2014-07-29 9:39 ` Tvrtko Ursulin
2014-07-23 13:23 ` [PATCH 1/2] drm/i915: Allow overlapping userptr objects Tvrtko Ursulin
2014-07-23 14:34 ` Daniel Vetter [this message]
2014-07-23 15:08 ` Tvrtko Ursulin
-- strict thread matches above, loose matches on Subject: below --
2014-07-10 9:21 Chris Wilson
2014-07-10 12:26 ` Tvrtko Ursulin
2014-07-10 12:40 ` Chris Wilson
2014-07-10 20:20 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723143422.GU15237@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akash.goel@intel.com \
--cc=bradley.d.volkin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox