From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] igt_core: Inject subtest message into dmesg
Date: Thu, 24 Jul 2014 16:02:19 +0200
Message-ID: <20140724140219.GD4747@phenom.ffwll.local>
References: <1406202513-14173-1-git-send-email-chris@chris-wilson.co.uk>
 <20140724123654.GB4747@phenom.ffwll.local>
 <CANkqdn2GO8WB2eNR_zFSgQJtF_Qhudj5Dm7ncSxYbx-Zxa=XJw@mail.gmail.com>
 <20140724135808.GJ29372@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170])
 by gabe.freedesktop.org (Postfix) with ESMTP id F22BB6E703
 for <intel-gfx@lists.freedesktop.org>; Thu, 24 Jul 2014 07:02:11 -0700 (PDT)
Received: by mail-wi0-f170.google.com with SMTP id f8so9286248wiw.3
 for <intel-gfx@lists.freedesktop.org>; Thu, 24 Jul 2014 07:02:11 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140724135808.GJ29372@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Thomas Wood <thomas.wood@intel.com>, Daniel Vetter <daniel@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Jul 24, 2014 at 02:58:08PM +0100, Chris Wilson wrote:
> On Thu, Jul 24, 2014 at 02:03:01PM +0100, Thomas Wood wrote:
> > On 24 July 2014 13:36, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Thu, Jul 24, 2014 at 12:48:33PM +0100, Chris Wilson wrote:
> > >> One of the side-effects we test for are kernel oops and knowing the
> > >> guilty subtest can help speed up debugging. We can write to /dev/kmsg to
> > >> inject messages into dmesg, so let's do so before the start of every
> > >> test.
> > >>
> > >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > >
> > > Should we change proc->comm too? Would help with the oops printing ... Ack
> > > on the patch itself.
> > 
> > It should also make sure that the log level is appropriate so that the
> > Piglit dmesg capture isn't triggered accidentally.
> 
> I found out how to set the log-level, so choose KERN_INFO which should be
> sufficient.
>  
> > Would it be useful to include this in simple tests (tests without
> > subtests) as well?
> 
> Definitely. Is there a way to do that automatically or do we need to
> adjust the tests themselves? I was thinkg we could add a kmsg() to
> common_init() to capture those.

common_init kmsg'ing the test binary should be good. That should help in
lining up any test setup work that's done before the first test starts,
too. So useful even with subtests.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch