From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 01/43] drm/i915: Reorder the actual workload submission so that args checking is done earlier Date: Fri, 25 Jul 2014 10:30:09 +0200 Message-ID: <20140725083009.GP4747@phenom.ffwll.local> References: <1406217891-8912-1-git-send-email-thomas.daniel@intel.com> <1406217891-8912-2-git-send-email-thomas.daniel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A4396E7E4 for ; Fri, 25 Jul 2014 01:30:01 -0700 (PDT) Received: by mail-wi0-f172.google.com with SMTP id n3so557250wiv.11 for ; Fri, 25 Jul 2014 01:30:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1406217891-8912-2-git-send-email-thomas.daniel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thomas Daniel Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMjQsIDIwMTQgYXQgMDU6MDQ6MDlQTSArMDEwMCwgVGhvbWFzIERhbmllbCB3 cm90ZToKPiBGcm9tOiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IAo+IElu IHRoaXMgcGF0Y2g6Cj4gCj4gY29tbWl0IDc4MzgyNTkzZTkyMWM4ODM3MWFiZDAxOWFjYTg5Nzhk YjMyNDhhOGYKPiBBdXRob3I6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4g RGF0ZTogICBUaHUgSnVsIDMgMTY6Mjg6MDUgMjAxNCArMDEwMAo+IAo+ICAgICBkcm0vaTkxNTog RXh0cmFjdCB0aGUgYWN0dWFsIHdvcmtsb2FkIHN1Ym1pc3Npb24gbWVjaGFuaXNtIGZyb20gZXhl Y2J1ZmZlcgo+IAo+ICAgICBTbyB0aGF0IHdlIGlzb2xhdGUgdGhlIGxlZ2FjeSByaW5nYnVmZmVy IHN1Ym1pc3Npb24gbWVjaGFuaXNtLCB3aGljaCBiZWNvbWVzCj4gICAgIGEgZ29vZCBjYW5kaWRh dGUgdG8gYmUgYWJzdHJhY3RlZCBhd2F5LiBUaGlzIGlzIHByZXAtd29yayBmb3IgRXhlY2xpc3Rz ICh3aGljaAo+ICAgICB3aWxsIGl0cyBvd24gd29ya2xvYWQgc3VibWlzc2lvbiBtZWNoYW5pc20p Lgo+IAo+ICAgICBObyBmdW5jdGlvbmFsIGNoYW5nZXMuCj4gCj4gSSBjaGFuZ2VkIHRoZSBvcmRl ciBpbiB3aGljaCB0aGUgYXJncyBjaGVja2luZyBpcyBkb25lLiBJIGRvbid0IGtub3cgd2h5IEkg ZGlkIChicmFpbgo+IGZhZGU/KSBidXQgaXTFmyBub3QgcmlnaHQuIEkgaGF2ZW4ndCBzZWVuIGFu eSBpbGwgZWZmZWN0IGZyb20gdGhpcywgYnV0IHRoZSBFeGVjbGlzdHMKPiB2ZXJzaW9uIG9mIHRo aXMgZnVuY3Rpb24gd2lsbCBoYXZlIHByb2JsZW1zIGlmIHRoZSBvcmRlciBpcyBub3QgY29ycmVj dC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29t PgoKSSBkb24ndCB0aGluayB0aGlzIG1hdHRlcnMgLSB0aGUgcG9pbnQgb2Ygbm8gcmV0dXJuIGZv ciBsZWdhY3kgZXhlY2J1ZiBpcwp0aGUgY2FsbCB0byByaW5nLT5kaXNwYXRjaC4gQWZ0ZXIgdGhh dCBub3RoaW5nIG1heSBmYWlsIGFueSBtb3JlLiBCdXQgYXMKbG9uZyBhcyB3ZSB0cmFjayBzdGF0 ZSBjb3JyZWN0bHkgKGUuZy4gaWYgd2UndmUgc3dpdGNoZWQgdGhlIGNvbnRleHQKYWxyZWFkeSkg d2UnbGwgYmUgZmluZS4KClNvIHByZXN1bWluZyBJJ20gbm90IGJsaW5kIEkgZG9udCcgdGhpbmsg dGhpcyBpcyBuZWVkZWQuIEJ1dCBtYXliZSBDaHJpcwpzcG90cyBzb21ldGhpbmcuCi1EYW5pZWwK PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jIHwgICA4 NiArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MyBpbnNl cnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fZXhlY2J1ZmZlci5jCj4gaW5kZXggNjA5OThmYy4uYzUxMTU5NTcgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gQEAgLTEwNDIsNiArMTA0 Miw0MyBAQCBsZWdhY3lfcmluZ2J1ZmZlcl9zdWJtaXNzaW9uKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiAgCXUzMiBpbnN0cF9tYXNrOwo+ICAJaW50IGks IHJldCA9IDA7Cj4gIAo+ICsJaW5zdHBfbW9kZSA9IGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0NP TlNUQU5UU19NQVNLOwo+ICsJaW5zdHBfbWFzayA9IEk5MTVfRVhFQ19DT05TVEFOVFNfTUFTSzsK PiArCXN3aXRjaCAoaW5zdHBfbW9kZSkgewo+ICsJY2FzZSBJOTE1X0VYRUNfQ09OU1RBTlRTX1JF TF9HRU5FUkFMOgo+ICsJY2FzZSBJOTE1X0VYRUNfQ09OU1RBTlRTX0FCU09MVVRFOgo+ICsJY2Fz ZSBJOTE1X0VYRUNfQ09OU1RBTlRTX1JFTF9TVVJGQUNFOgo+ICsJCWlmIChpbnN0cF9tb2RlICE9 IDAgJiYgcmluZyAhPSAmZGV2X3ByaXYtPnJpbmdbUkNTXSkgewo+ICsJCQlEUk1fREVCVUcoIm5v bi0wIHJlbCBjb25zdGFudHMgbW9kZSBvbiBub24tUkNTXG4iKTsKPiArCQkJcmV0ID0gLUVJTlZB TDsKPiArCQkJZ290byBlcnJvcjsKPiArCQl9Cj4gKwo+ICsJCWlmIChpbnN0cF9tb2RlICE9IGRl dl9wcml2LT5yZWxhdGl2ZV9jb25zdGFudHNfbW9kZSkgewo+ICsJCQlpZiAoSU5URUxfSU5GTyhk ZXYpLT5nZW4gPCA0KSB7Cj4gKwkJCQlEUk1fREVCVUcoIm5vIHJlbCBjb25zdGFudHMgb24gcHJl LWdlbjRcbiIpOwo+ICsJCQkJcmV0ID0gLUVJTlZBTDsKPiArCQkJCWdvdG8gZXJyb3I7Cj4gKwkJ CX0KPiArCj4gKwkJCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+IDUgJiYKPiArCQkJICAgIGlu c3RwX21vZGUgPT0gSTkxNV9FWEVDX0NPTlNUQU5UU19SRUxfU1VSRkFDRSkgewo+ICsJCQkJRFJN X0RFQlVHKCJyZWwgc3VyZmFjZSBjb25zdGFudHMgbW9kZSBpbnZhbGlkIG9uIGdlbjUrXG4iKTsK PiArCQkJCXJldCA9IC1FSU5WQUw7Cj4gKwkJCQlnb3RvIGVycm9yOwo+ICsJCQl9Cj4gKwo+ICsJ CQkvKiBUaGUgSFcgY2hhbmdlZCB0aGUgbWVhbmluZyBvbiB0aGlzIGJpdCBvbiBnZW42ICovCj4g KwkJCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA2KQo+ICsJCQkJaW5zdHBfbWFzayAmPSB+ STkxNV9FWEVDX0NPTlNUQU5UU19SRUxfU1VSRkFDRTsKPiArCQl9Cj4gKwkJYnJlYWs7Cj4gKwlk ZWZhdWx0Ogo+ICsJCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRoIHVua25vd24gY29uc3RhbnRzOiAl ZFxuIiwgaW5zdHBfbW9kZSk7Cj4gKwkJcmV0ID0gLUVJTlZBTDsKPiArCQlnb3RvIGVycm9yOwo+ ICsJfQo+ICsKPiAgCWlmIChhcmdzLT5udW1fY2xpcHJlY3RzICE9IDApIHsKPiAgCQlpZiAocmlu ZyAhPSAmZGV2X3ByaXYtPnJpbmdbUkNTXSkgewo+ICAJCQlEUk1fREVCVUcoImNsaXAgcmVjdGFu Z2xlcyBhcmUgb25seSB2YWxpZCB3aXRoIHRoZSByZW5kZXIgcmluZ1xuIik7Cj4gQEAgLTEwODUs NiArMTEyMiwxMiBAQCBsZWdhY3lfcmluZ2J1ZmZlcl9zdWJtaXNzaW9uKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJaWYg KGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0dFTjdfU09MX1JFU0VUKSB7Cj4gKwkJcmV0ID0gaTkx NV9yZXNldF9nZW43X3NvbF9vZmZzZXRzKGRldiwgcmluZyk7Cj4gKwkJaWYgKHJldCkKPiArCQkJ Z290byBlcnJvcjsKPiArCX0KPiArCj4gIAlyZXQgPSBpOTE1X2dlbV9leGVjYnVmZmVyX21vdmVf dG9fZ3B1KHJpbmcsIHZtYXMpOwo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGVycm9yOwo+IEBAIC0x MDkzLDQzICsxMTM2LDYgQEAgbGVnYWN5X3JpbmdidWZmZXJfc3VibWlzc2lvbihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsCj4gIAlpZiAocmV0KQo+ICAJCWdv dG8gZXJyb3I7Cj4gIAo+IC0JaW5zdHBfbW9kZSA9IGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0NP TlNUQU5UU19NQVNLOwo+IC0JaW5zdHBfbWFzayA9IEk5MTVfRVhFQ19DT05TVEFOVFNfTUFTSzsK PiAtCXN3aXRjaCAoaW5zdHBfbW9kZSkgewo+IC0JY2FzZSBJOTE1X0VYRUNfQ09OU1RBTlRTX1JF TF9HRU5FUkFMOgo+IC0JY2FzZSBJOTE1X0VYRUNfQ09OU1RBTlRTX0FCU09MVVRFOgo+IC0JY2Fz ZSBJOTE1X0VYRUNfQ09OU1RBTlRTX1JFTF9TVVJGQUNFOgo+IC0JCWlmIChpbnN0cF9tb2RlICE9 IDAgJiYgcmluZyAhPSAmZGV2X3ByaXYtPnJpbmdbUkNTXSkgewo+IC0JCQlEUk1fREVCVUcoIm5v bi0wIHJlbCBjb25zdGFudHMgbW9kZSBvbiBub24tUkNTXG4iKTsKPiAtCQkJcmV0ID0gLUVJTlZB TDsKPiAtCQkJZ290byBlcnJvcjsKPiAtCQl9Cj4gLQo+IC0JCWlmIChpbnN0cF9tb2RlICE9IGRl dl9wcml2LT5yZWxhdGl2ZV9jb25zdGFudHNfbW9kZSkgewo+IC0JCQlpZiAoSU5URUxfSU5GTyhk ZXYpLT5nZW4gPCA0KSB7Cj4gLQkJCQlEUk1fREVCVUcoIm5vIHJlbCBjb25zdGFudHMgb24gcHJl LWdlbjRcbiIpOwo+IC0JCQkJcmV0ID0gLUVJTlZBTDsKPiAtCQkJCWdvdG8gZXJyb3I7Cj4gLQkJ CX0KPiAtCj4gLQkJCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+IDUgJiYKPiAtCQkJICAgIGlu c3RwX21vZGUgPT0gSTkxNV9FWEVDX0NPTlNUQU5UU19SRUxfU1VSRkFDRSkgewo+IC0JCQkJRFJN X0RFQlVHKCJyZWwgc3VyZmFjZSBjb25zdGFudHMgbW9kZSBpbnZhbGlkIG9uIGdlbjUrXG4iKTsK PiAtCQkJCXJldCA9IC1FSU5WQUw7Cj4gLQkJCQlnb3RvIGVycm9yOwo+IC0JCQl9Cj4gLQo+IC0J CQkvKiBUaGUgSFcgY2hhbmdlZCB0aGUgbWVhbmluZyBvbiB0aGlzIGJpdCBvbiBnZW42ICovCj4g LQkJCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA2KQo+IC0JCQkJaW5zdHBfbWFzayAmPSB+ STkxNV9FWEVDX0NPTlNUQU5UU19SRUxfU1VSRkFDRTsKPiAtCQl9Cj4gLQkJYnJlYWs7Cj4gLQlk ZWZhdWx0Ogo+IC0JCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRoIHVua25vd24gY29uc3RhbnRzOiAl ZFxuIiwgaW5zdHBfbW9kZSk7Cj4gLQkJcmV0ID0gLUVJTlZBTDsKPiAtCQlnb3RvIGVycm9yOwo+ IC0JfQo+IC0KPiAgCWlmIChyaW5nID09ICZkZXZfcHJpdi0+cmluZ1tSQ1NdICYmCj4gIAkJCWlu c3RwX21vZGUgIT0gZGV2X3ByaXYtPnJlbGF0aXZlX2NvbnN0YW50c19tb2RlKSB7Cj4gIAkJcmV0 ID0gaW50ZWxfcmluZ19iZWdpbihyaW5nLCA0KTsKPiBAQCAtMTE0NSwxMiArMTE1MSw2IEBAIGxl Z2FjeV9yaW5nYnVmZmVyX3N1Ym1pc3Npb24oc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0 IGRybV9maWxlICpmaWxlLAo+ICAJCWRldl9wcml2LT5yZWxhdGl2ZV9jb25zdGFudHNfbW9kZSA9 IGluc3RwX21vZGU7Cj4gIAl9Cj4gIAo+IC0JaWYgKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0dF TjdfU09MX1JFU0VUKSB7Cj4gLQkJcmV0ID0gaTkxNV9yZXNldF9nZW43X3NvbF9vZmZzZXRzKGRl diwgcmluZyk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJZ290byBlcnJvcjsKPiAtCX0KPiAtCj4gIAll eGVjX2xlbiA9IGFyZ3MtPmJhdGNoX2xlbjsKPiAgCWlmIChjbGlwcmVjdHMpIHsKPiAgCQlmb3Ig KGkgPSAwOyBpIDwgYXJncy0+bnVtX2NsaXByZWN0czsgaSsrKSB7Cj4gLS0gCj4gMS43LjkuNQo+ IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQx ICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=