From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] intel-gpu-tools: skip gem_mmap_offset_exhaustion on Android Date: Fri, 25 Jul 2014 11:06:38 +0200 Message-ID: <20140725090638.GS4747@phenom.ffwll.local> References: <1406278819-8464-1-git-send-email-tim.gore@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F0D36E2F3 for ; Fri, 25 Jul 2014 02:06:30 -0700 (PDT) Received: by mail-wi0-f182.google.com with SMTP id d1so610764wiv.9 for ; Fri, 25 Jul 2014 02:06:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1406278819-8464-1-git-send-email-tim.gore@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: tim.gore@intel.com Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Jul 25, 2014 at 10:00:19AM +0100, tim.gore@intel.com wrote: > From: Tim Gore > > gem_mmap_offset_exhaustion relies on purgeable memory > allocations getting swapped out, freeing up physical > memory for further allocations. On Android we have no > swap partition so this cannot happen and the test gets > killed by the low memory killer before mmap offset > exhaustion can happen, thus defeating the tests purpose. > > Signed-off-by: Tim Gore /* we happily leak objects to exhaust mmap offset space, the kernel will * reap backing storage. */ gem_madvise(fd, handle, I915_MADV_DONTNEED); There's really no way you should be able to run out of memory. I suspect android kernel's will fall over even with swap. -Daniel > --- > tests/gem_mmap_offset_exhaustion.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/gem_mmap_offset_exhaustion.c b/tests/gem_mmap_offset_exhaustion.c > index 914fe6e..016143d 100644 > --- a/tests/gem_mmap_offset_exhaustion.c > +++ b/tests/gem_mmap_offset_exhaustion.c > @@ -77,6 +77,10 @@ igt_simple_main > { > int fd, i; > > +#ifdef ANDROID > + igt_skip("Test not valid on Android\n"); > +#endif > + > igt_skip_on_simulation(); > > fd = drm_open_any(); > -- > 1.9.2 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch