public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel@ffwll.ch>,
	tim.gore@intel.com, daniel.vetter@ffwll.ch,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel-gpu-tools: skip gem_mmap_offset_exhaustion on Android
Date: Fri, 25 Jul 2014 11:37:18 +0200	[thread overview]
Message-ID: <20140725093718.GT4747@phenom.ffwll.local> (raw)
In-Reply-To: <20140725091726.GD7661@nuc-i3427.alporthouse.com>

On Fri, Jul 25, 2014 at 10:17:26AM +0100, Chris Wilson wrote:
> On Fri, Jul 25, 2014 at 11:06:38AM +0200, Daniel Vetter wrote:
> > On Fri, Jul 25, 2014 at 10:00:19AM +0100, tim.gore@intel.com wrote:
> > > From: Tim Gore <tim.gore@intel.com>
> > > 
> > > gem_mmap_offset_exhaustion relies on purgeable memory
> > > allocations getting swapped out, freeing up physical
> > > memory for further allocations. On Android we have no
> > > swap partition so this cannot happen and the test gets
> > > killed by the low memory killer before mmap offset
> > > exhaustion can happen, thus defeating the tests purpose.
> > > 
> > > Signed-off-by: Tim Gore <tim.gore@intel.com>
> > 
> > 
> > 
> > 	/* we happily leak objects to exhaust mmap offset space, the kernel will
> > 	 * reap backing storage. */
> > 	gem_madvise(fd, handle, I915_MADV_DONTNEED);
> > 
> > There's really no way you should be able to run out of memory. I suspect
> > android kernel's will fall over even with swap.
> 
> No, it's just the android lowmemkiller hates i915 by design. The two are
> more or less incompatible.

Well someone should fix up the lowmemkiller then. Disabling the test is
not really fixing it.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-07-25  9:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25  9:00 [PATCH] intel-gpu-tools: skip gem_mmap_offset_exhaustion on Android tim.gore
2014-07-25  9:06 ` Daniel Vetter
2014-07-25  9:14   ` Gore, Tim
2014-07-25  9:39     ` Daniel Vetter
2014-07-25  9:17   ` Chris Wilson
2014-07-25  9:37     ` Daniel Vetter [this message]
2014-07-25  9:56       ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725093718.GT4747@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tim.gore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox