Re: [PATCH v2] drm/i915/bdw: BDW Software Turbo

Chris Wilson
2014-07-11T06:16:00Z

On Thu, Jul 10, 2014 at 07:39:32PM -0700, Sun, Daisy wrote:
>
> This Software turbo will mainly take place of the hardware driven
> interrupt part without touching the boost/idle strategy.
> So gen6_rps_boost and gen6_rps_idle will still function for BDW.

You still are not addressing that your function is either called at a
random time, and more often than not, never. You also disabled the
set_rps paths which would have disabled boost and idle.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre