Re: [PATCH v2] drm/i915/bdw: BDW Software Turbo

Sun, Daisy
2014-07-14T04:22:46Z

1) The design is by no means to disable boost and idle strategy. They are every effective dealing with burst request, bring up the responsiveness.

2) The patch did disable part of gen6_set_rps_thresholds(), but gen6_set_rps is supposed to function the same as before.
Would you point out the code which is suspicious to disable set_rps path?

3) The function will be called when flip happened, this should cover most of the cases. One exception is background media process without any display output, it's relatively rare.
Please let me know if you have concern on other cases, I will try to cover it definitely.

-----Original Message-----
From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
Sent: Thursday, July 10, 2014 11:16 PM
To: Sun, Daisy
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

On Thu, Jul 10, 2014 at 07:39:32PM -0700, Sun, Daisy wrote:
>
> This Software turbo will mainly take place of the hardware driven
> interrupt part without touching the boost/idle strategy.
> So gen6_rps_boost and gen6_rps_idle will still function for BDW.

You still are not addressing that your function is either called at a random time, and more often than not, never. You also disabled the set_rps paths which would have disabled boost and idle.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre