From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 0/3] Fixes for runtime PM on planes APIs Date: Mon, 28 Jul 2014 16:25:45 -0700 Message-ID: <20140728232545.GN16114@intel.com> References: <1406572636-1809-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 979E26E260 for ; Mon, 28 Jul 2014 16:26:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1406572636-1809-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Mon, Jul 28, 2014 at 03:37:11PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Hi > > This series fixes some bugs that happen when we're runtime suspended and try to > use the planes APIs. I also wrote IGT test cases for the bugs, so we will be > able to detect future regressions. > > The controversial part of these patches is that we had previously defined that > we wanted to get/put runtime PM in the highest level of the stack, wrapping as > much code as possible, but Daniel asked me to only get/put runtime PM around the > functions that pin the objects (still on the highest level, but only around the > pin functions). This series implements Daniel's suggestions. These look pretty straightforward to me, so for all three: Reviewed-by: Matt Roper However as a side note on the runtime PM stuff I'll admit that it's not an area I'd previously paid too much attention to and my first reaction looking at the patches was "I wonder if intel_runtime_pm_{get,put} could be pushed down into intel_pin_and_fence_fb_obj()." Until I read your cover letter I wasn't aware of the goal of "get/put runtime PM in the highest level of the stack, wrapping as much code as possible" and I don't think that's really explained anywhere in the code or in the commit log today. Maybe we could add a comment in intel_pm.c explaining that design goal for future contributors/reviewers? Matt > > Thanks, > Paulo > > > Paulo Zanoni (3): > drm/i915: fix cursor handling when runtime suspended > drm/i915: get runtime PM when pinning sprite objects > drm/i915: get runtime PM when pinning primary plane objects > > drivers/gpu/drm/i915/intel_display.c | 9 +++++++++ > drivers/gpu/drm/i915/intel_sprite.c | 3 +++ > 2 files changed, 12 insertions(+) > > -- > 2.0.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795