From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: s/seqno/request/ tracking inside objects Date: Tue, 29 Jul 2014 07:54:27 -0700 Message-ID: <20140729075427.7ecf4dac@jbarnes-desktop> References: <1406291220-14151-1-git-send-email-chris@chris-wilson.co.uk> <20140728134412.6d3b5a10@jbarnes-t420> <20140729072953.GB21570@nuc-i3427.alporthouse.com> <20140729104126.GP4747@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by gabe.freedesktop.org (Postfix) with ESMTP id BF4AF6E3C0 for ; Tue, 29 Jul 2014 07:54:23 -0700 (PDT) Received: by mail-pa0-f42.google.com with SMTP id lf10so12446823pab.15 for ; Tue, 29 Jul 2014 07:54:23 -0700 (PDT) In-Reply-To: <20140729104126.GP4747@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Brad Volkin List-Id: intel-gfx@lists.freedesktop.org On Tue, 29 Jul 2014 12:41:26 +0200 Daniel Vetter wrote: > On Tue, Jul 29, 2014 at 08:29:53AM +0100, Chris Wilson wrote: > > On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote: > > > > @@ -3038,44 +3203,35 @@ out: > > > > */ > > > > int > > > > i915_gem_object_sync(struct drm_i915_gem_object *obj, > > > > - struct intel_engine_cs *to) > > > > + struct intel_engine_cs *to, > > > > + bool readonly) > > > > { > > > > > > It might be nice to have sync_read/sync_write functions instead, since > > > looking up bool args or unnamed enums is a pain. > > > > Not convinced since it is used in a single location and two function > > calls would look unelegant - but we could switch to PROT_READ | > > PROT_WRITE throughout. > > Switching to PROT_READ/WRITE might be nice as a general cleanup (or some > other named thing) since read_only/write booleans are all over the place. > So I like this, but definitely something for a separate patch. Agreed, that's a good idea. -- Jesse Barnes, Intel Open Source Technology Center