From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Oscar Mateo <oscar.mateo@intel.com>,
Brad Volkin <bradley.d.volkin@intel.com>
Subject: Re: [PATCH] drm/i915: s/seqno/request/ tracking inside objects
Date: Tue, 29 Jul 2014 12:41:26 +0200 [thread overview]
Message-ID: <20140729104126.GP4747@phenom.ffwll.local> (raw)
In-Reply-To: <20140729072953.GB21570@nuc-i3427.alporthouse.com>
On Tue, Jul 29, 2014 at 08:29:53AM +0100, Chris Wilson wrote:
> On Mon, Jul 28, 2014 at 01:44:12PM -0700, Jesse Barnes wrote:
> > > @@ -3038,44 +3203,35 @@ out:
> > > */
> > > int
> > > i915_gem_object_sync(struct drm_i915_gem_object *obj,
> > > - struct intel_engine_cs *to)
> > > + struct intel_engine_cs *to,
> > > + bool readonly)
> > > {
> >
> > It might be nice to have sync_read/sync_write functions instead, since
> > looking up bool args or unnamed enums is a pain.
>
> Not convinced since it is used in a single location and two function
> calls would look unelegant - but we could switch to PROT_READ |
> PROT_WRITE throughout.
Switching to PROT_READ/WRITE might be nice as a general cleanup (or some
other named thing) since read_only/write booleans are all over the place.
So I like this, but definitely something for a separate patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-07-29 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 12:27 [PATCH] drm/i915: s/seqno/request/ tracking inside objects Chris Wilson
2014-07-28 16:24 ` Daniel Vetter
2014-07-28 20:44 ` Jesse Barnes
2014-07-29 6:53 ` Chris Wilson
2014-07-29 7:29 ` Chris Wilson
2014-07-29 10:41 ` Daniel Vetter [this message]
2014-07-29 14:54 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2014-07-25 12:19 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729104126.GP4747@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bradley.d.volkin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox