From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 2/2] drm/i915: fix VDD state tracking after system resume Date: Wed, 30 Jul 2014 15:41:07 +0200 Message-ID: <20140730134107.GQ4747@phenom.ffwll.local> References: <1406725052-31791-1-git-send-email-imre.deak@intel.com> <1406725052-31791-2-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by gabe.freedesktop.org (Postfix) with ESMTP id EBBEB6E616 for ; Wed, 30 Jul 2014 06:40:59 -0700 (PDT) Received: by mail-we0-f172.google.com with SMTP id x48so1244982wes.31 for ; Wed, 30 Jul 2014 06:40:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1406725052-31791-2-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jul 30, 2014 at 03:57:32PM +0300, Imre Deak wrote: > Just like during booting the BIOS can leave the VDD bit enabled after > system resume. So apply the same state sanitization there too. This > fixes a problem where after resume the port power domain refcount gets > unbalanced. > = > Reported-and-tested-by: Jarkko Nikula > Signed-off-by: Imre Deak > Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_display.c | 6 ++++++ > 1 file changed, 6 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 1edfd1a..fdb5657 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -12977,6 +12977,12 @@ void intel_modeset_setup_hw_state(struct drm_dev= ice *dev, > /* HW state is read out, now we need to sanitize this mess. */ > list_for_each_entry(encoder, &dev->mode_config.encoder_list, > base.head) { > + /* > + * Do the following only during resume, since at driver > + * loading it's done early when initializing the encoder. > + */ > + if (force_restore) > + intel_edp_panel_vdd_sanitize(encoder); This should be put into an encoder->reset callback. -Daniel > intel_sanitize_encoder(encoder); > } > = > -- = > 1.8.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch