From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 7/8] drm/irq: Implement a generic vblank_wait function Date: Wed, 30 Jul 2014 16:24:06 +0200 Message-ID: <20140730142405.GP29590@ulmo> References: <1406669543-31213-1-git-send-email-daniel.vetter@ffwll.ch> <1406669543-31213-8-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1289606128==" Return-path: In-Reply-To: <1406669543-31213-8-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============1289606128== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oCBD0SPT9UHZkBMO" Content-Disposition: inline --oCBD0SPT9UHZkBMO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 29, 2014 at 11:32:22PM +0200, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c [...] > + ret = wait_event_timeout(dev->vblank[crtc].queue, > + C, msecs_to_jiffies(100)); 100 milliseconds looks like a very arbitrary choice. Theoretically we support things like crtc->mode.vrefresh = 5, so I wonder if we should parameterize this on the refresh rate, or simply increase it further? Thierry --oCBD0SPT9UHZkBMO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT2QAFAAoJEN0jrNd/PrOh+lsQAKe/YMphtxWk9LZrH+z6B9Y3 F1tdzmhu2M9RMpD8ygQW6j3fLDh2a/BCjxZapeiwto+7HNU3zNY4RMsmVF8AQA+e FY/4uj3z6dUYEvqNdlk147tXZdTS5ELXc5IJOWkhq4LWNNt9jD5mhXLj2VslBsGd 4z3KcRhglipnHqvShQfsn/HlcXO/HQ7cQY1W6m9+t5pbTcdY9ENGqXefeuCH9xnf zD067S+ROJDsVpWMgPSlfH/4/yfbwHVI7Z9uRHtDdyKWG6kNJSDOZewKLZZi50xr H3veJTZPo5tOhPDgPE2KtimlnnALjpEyO2cASJpIz9eA1VGMMLlNY39BJ0LhIuvc n0pZ9d6WHmj6o6GVwjYXylkIqZ1tdlGC2Tvgyf+m4iHCuIppPKHJQF3K5a042Q37 dlXZl9/ZF9AvwRs4sDap6sC67u3KT4M5uHX5ZXWutXixBoK2std6JCRw8l2C0Y9W cGjJro4bw0jc4/mSw8g0tkE7DFmSblrGfuTSSauk5deh8gLUBtZNaURbrd24+e4i Lo00DAmZgh9dm3xaeH2nciu7Y7+ZmywVTnOEdq7kzFH3bk473jeR+5+PJYKmdcg1 q2PILn8gmHQKSbpHpwcN9l4zfIO9VOkjjQc+PZ0AtG2mbjjk7RhpW4rYh5IrHlVj ebLmmGfpza3ST3L5r3T7 =Hkf7 -----END PGP SIGNATURE----- --oCBD0SPT9UHZkBMO-- --===============1289606128== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1289606128==--