Re: [PATCH] drm/irq: Implement a generic vblank_wait function

Michel Dänzer
2014-07-30T09:52:41Z

On 30.07.2014 18:25, Daniel Vetter wrote:
> As usual in both a crtc index and a struct drm_crtc * version.
>
> The function assumes that no one drivers their display below 10Hz, and
> it will complain if the vblank wait takes longer than that.
>
> v2: Also check dev->max_vblank_counter since some drivers register a
> fake get_vblank_counter function.
>
> v3: Use drm_vblank_count instead of calling the low-level
> ->get_vblank_counter callback. That way we'll get the sw-cooked
> counter for platforms without proper vblank support and so can ditch
> the max_vblank_counter check again.
>
> v4: Review from Michel Dänzer:
> - Restore lost notes about v3:
> - Spelling in kerneldoc.
> - Inline wait_event condition.
> - s/vblank_wait/wait_one_vblank/
>
> Cc: Michel Dänzer <michel@daenzer.net>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org