Re: [PATCH 7/8] drm/irq: Implement a generic vblank_wait function

Michel Dänzer
2014-07-30T08:32:28Z

On 30.07.2014 17:22, Daniel Vetter wrote:
> On Wed, Jul 30, 2014 at 11:59:33AM +0900, Michel Dänzer wrote:
>> On 30.07.2014 06:32, Daniel Vetter wrote:
>>> + * due to lack of driver support or because the crtc is off.
>>> + */
>>> +void drm_crtc_vblank_wait(struct drm_crtc *crtc)
>>> +{
>>> + drm_vblank_wait(crtc->dev, drm_crtc_index(crtc));
>>> +}
>>> +EXPORT_SYMBOL(drm_crtc_vblank_wait);
>>> +
>>> +/**
>>
>> Maybe the function names should be *_vblank_wait_next() or something to
>> clarify the purpose and reduce potential confusion versus drm_wait_vblank().
>
> Yeah that name is just transferred from the i915 driver. What about
> drm_wait_one_vblank()/drm_crtc_wait_one_vblank()?

I don't care that much :), go ahead.

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer