Re: [PATCH 4/8] drm: Move ->old_fb from crtc to plane

Dave Airlie
2014-07-29T23:30:19Z

On 30 July 2014 07:32, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Atomic implemenations for legacy ioctls must be able to drop locks.
> Which doesn't cause havoc since we only do that while constructing
> the new state, so no driver or hardware state change has happened.
>
> The only troubling bit is the fb refcounting the core does - if
> someone else has snuck in then it might potentially unref an
> outdated framebuffer. To fix that move the old_fb temporary storage
> into struct drm_plane for all ioctls, so that the atomic helpers can
> update it.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Seems to make sense to me.

Reviewed-by: Dave Airlie <airlied@redhat.com>