From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 7/8] drm/irq: Implement a generic vblank_wait function Date: Wed, 30 Jul 2014 17:10:42 +0200 Message-ID: <20140730151041.GC1345@ulmo> References: <1406669543-31213-1-git-send-email-daniel.vetter@ffwll.ch> <1406669543-31213-8-git-send-email-daniel.vetter@ffwll.ch> <20140730142405.GP29590@ulmo> <20140730150637.GS4747@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1991643989==" Return-path: In-Reply-To: <20140730150637.GS4747@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============1991643989== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bAmEntskrkuBymla" Content-Disposition: inline --bAmEntskrkuBymla Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 30, 2014 at 05:06:38PM +0200, Daniel Vetter wrote: > On Wed, Jul 30, 2014 at 04:24:06PM +0200, Thierry Reding wrote: > > On Tue, Jul 29, 2014 at 11:32:22PM +0200, Daniel Vetter wrote: > > [...] > > > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > > [...] > > > + ret =3D wait_event_timeout(dev->vblank[crtc].queue, > > > + C, msecs_to_jiffies(100)); > >=20 > > 100 milliseconds looks like a very arbitrary choice. Theoretically we > > support things like crtc->mode.vrefresh =3D 5, so I wonder if we should > > parameterize this on the refresh rate, or simply increase it further? >=20 > Once we have 10Hz panels I think we can pump/fix this. In i915 we've used > 50ms everywhere, and never hit this. Except when driver bugs, ofc. Okay, fair enough. Thierry --bAmEntskrkuBymla Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT2QrxAAoJEN0jrNd/PrOhuwUP/jUW0t3xGihaR96zIrsJnWmO ERacrcCO7YiSmHftJrSbgmVtIg7Sd+2AIVlx73SRYUFkJg3VeekPoWdJNzNro+Zl 2/M01ACWMaAo09uut4GaHvATnTXk8cf3OIj7tTGJh3BPGBqW/t7AFqSW3fGVKf+b kFZuiJ7ne9T39I9QIygXKfxSC1a97xjdEVrTIMXWY2JEwAkuzWg1Td6WypwNMFB2 TuXvCuJahUYsULEGgmGOYg+bWDpNnRhASpYhbkJnDC3NmhcsFdxi6nBJXdXLmUSn CZGzZFqMD0thv/83NIAucLE5KHEwWScDpyDgzqwJOcRiTGX82kM9/4RJdGqdacM+ ZA5JuKergtqNsbHtALDOzu9Zc196dwuvO82BjGX+0mXJJbb1WIC5jn/CFY+pMizX b9RyMsasS7CD9Ck8C+41fVduvgfLMydusqpfyKasydpdLavrvNP4A/Mn8zi2quCx Wlaumw4od2uXN0xir8f7A2dcdX9ruEwfeFpSvis4hOWU8HTtKK87wqmZSv8XGQfV P3vAapsXfqgWsLdm/+oZeFnvrz9tAQKuu7J0+SW5675Deo5uLUkNB0u8cZlPgbwd 0K7vYANuJ/x51aJob16Zki7Zq7j7KqFddbi6p5qkuqMbq37K/8nywVDUnxcWAbqg a0Fz/RiMZ8KR6ObB9Jat =NWV5 -----END PGP SIGNATURE----- --bAmEntskrkuBymla-- --===============1991643989== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1991643989==--