From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 09/12] Do more checks for proposed flip
 pixmaps
Date: Thu, 31 Jul 2014 17:43:18 +0300
Message-ID: <20140731144318.GO4193@intel.com>
References: <1406243908-1123-1-git-send-email-keithp@keithp.com>
 <1406243908-1123-10-git-send-email-keithp@keithp.com>
 <87a97qe1ia.fsf@eliezer.anholt.net>
 <864mxydq2b.fsf@hiro.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <864mxydq2b.fsf@hiro.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Keith Packard <keithp@keithp.com>
Cc: xorg-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 30, 2014 at 11:01:48PM -0700, Keith Packard wrote:
> Eric Anholt <eric@anholt.net> writes:
> =

> > Keith Packard <keithp@keithp.com> writes:
> >
> >> Make sure the pitch and tiling are correct.
> >> Make sure there's a BO we can get at.
> >
> > I thought we couldn't change these parameters, but now I can't find what
> > prevents them from changing.  Can you cite sources?
> =

> Looks like we *can* change tiling format. That actually makes me kinda
> happy as that explains why we were able to allocate a linear frame
> buffer for the X front buffer (due to a bug) and page flip to DRI3
> buffers which are always tiled.
> =

> However, we can't change the pitch. From the kernel driver:
> =

> 	/*
> 	 * TILEOFF/LINOFF registers can't be changed via MI display flips.
> 	 * Note that pitch changes could also affect these register.
> 	 */
> 	if (INTEL_INFO(dev)->gen > 3 &&
> 	    (fb->offsets[0] !=3D crtc->primary->fb->offsets[0] ||
> 	     fb->pitches[0] !=3D crtc->primary->fb->pitches[0]))
> 		return -EINVAL;
> =

> I'll remove the tiling check.

Now that we have mmio flips in the kernel we can start to relax that
restriction. That still needs a bit more work in the mmio flip code
but I believe some people working on just that.

We could even change the pixel format, except a check was added to
drm_mode_page_flip_ioctl() to prevent that, so I guess it was
deemed that the API isn't meant to allow that.

-- =

Ville Syrj=E4l=E4
Intel OTC