From: "Ville Syrjälä" <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Keith Packard <keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [Intel-gfx] [PATCH 09/12] Do more checks for proposed flip pixmaps
Date: Thu, 31 Jul 2014 19:06:50 +0300 [thread overview]
Message-ID: <20140731160650.GQ4193@intel.com> (raw)
In-Reply-To: <86a97pd07f.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org>
On Thu, Jul 31, 2014 at 08:20:20AM -0700, Keith Packard wrote:
> Ville Syrjälä <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> writes:
>
> > Now that we have mmio flips in the kernel we can start to relax that
> > restriction. That still needs a bit more work in the mmio flip code
> > but I believe some people working on just that.
>
> I couldn't find any tiling restrictions in the current (ring-based) flip
> code; did I just miss them?
No, changing tiling is supposed to work via cs flips. Except it
doesn't actually work on VLV for some reason. We now fall back to
mmio flip on VLV for that, so given a recent enough kernel it should
just work (tm) on all platforms.
I was referring to the relaxing the restrictions on stride changes.
>
> > We could even change the pixel format, except a check was added to
> > drm_mode_page_flip_ioctl() to prevent that, so I guess it was
> > deemed that the API isn't meant to allow that.
>
> Yeah, not sure I care about this; 32bpp is pretty much the only format I
> want.
You just need to be careful with the X vs. A because the kernel
considers those distinct pixel formats. I now regret adding that
distinciton to the pixel formats, but sadly I don't own a time
machine so I can't undo it.
--
Ville Syrjälä
Intel OTC
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
prev parent reply other threads:[~2014-07-31 16:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 23:18 [PATCH 00/12] Rework intel 2D driver glamor support Keith Packard
2014-07-24 23:18 ` [PATCH 01/12] Stop trying to out-guess mesa for BO allocation Keith Packard
[not found] ` <1406243908-1123-2-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 1:28 ` Eric Anholt
2014-07-31 5:45 ` Keith Packard
2014-08-04 16:58 ` Eric Anholt
2014-08-05 5:01 ` Keith Packard
2014-07-24 23:18 ` [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps Keith Packard
[not found] ` <1406243908-1123-4-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 1:33 ` Eric Anholt
2014-07-31 5:49 ` Keith Packard
2014-08-04 16:58 ` Eric Anholt
2014-07-24 23:18 ` [PATCH 04/12] Move intel_alloc_framebuffer to intel_memory.c Keith Packard
2014-07-24 23:18 ` [PATCH 05/12] Rename uxa-specific functions and structs Keith Packard
2014-07-24 23:18 ` [PATCH 06/12] Remove glamor support from UXA acceleration Keith Packard
[not found] ` <1406243908-1123-7-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 1:42 ` Eric Anholt
2014-07-31 5:52 ` Keith Packard
[not found] ` <1406243908-1123-1-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-24 23:18 ` [PATCH 02/12] Fix present debug output Keith Packard
2014-07-24 23:18 ` [PATCH 07/12] Add intel_flush to abstract flushing pending acceleration operations Keith Packard
[not found] ` <1406243908-1123-8-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 1:44 ` Eric Anholt
2014-07-24 23:18 ` [PATCH 08/12] Get rid of glamor stubs in intel_glamor.h Keith Packard
[not found] ` <1406243908-1123-9-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 1:47 ` Eric Anholt
2014-07-31 5:53 ` Keith Packard
2014-07-24 23:18 ` [PATCH 10/12] Add glamor back into the driver Keith Packard
[not found] ` <1406243908-1123-11-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 2:28 ` Eric Anholt
[not found] ` <8761iedzxh.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2014-07-31 6:23 ` Keith Packard
2014-07-24 23:18 ` [PATCH 11/12] Add "none" acceleration option Keith Packard
2014-07-24 23:18 ` [PATCH 12/12] Delay initial modeset until root window contents are prepared Keith Packard
2014-07-31 2:29 ` [PATCH 00/12] Rework intel 2D driver glamor support Eric Anholt
2014-07-31 6:25 ` Keith Packard
2014-07-31 6:56 ` Keith Packard
2014-07-24 23:18 ` [PATCH 09/12] Do more checks for proposed flip pixmaps Keith Packard
[not found] ` <1406243908-1123-10-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2014-07-31 1:54 ` Eric Anholt
2014-07-31 6:01 ` Keith Packard
2014-07-31 14:43 ` Ville Syrjälä
2014-07-31 15:20 ` Keith Packard
[not found] ` <86a97pd07f.fsf-6d7jPg3SX/+z9DMzp4kqnw@public.gmane.org>
2014-07-31 16:06 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731160650.GQ4193@intel.com \
--to=ville.syrjala-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org \
--cc=xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox