From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 34/43] drm/i915/bdw: Make sure gpu reset still works with Execlists Date: Fri, 1 Aug 2014 15:46:24 +0100 Message-ID: <20140801144624.GO8840@strange.ger.corp.intel.com> References: <1406217891-8912-1-git-send-email-thomas.daniel@intel.com> <1406217891-8912-35-git-send-email-thomas.daniel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AA8666E78D for ; Fri, 1 Aug 2014 07:46:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1406217891-8912-35-git-send-email-thomas.daniel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thomas Daniel Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 24, 2014 at 05:04:42PM +0100, Thomas Daniel wrote: > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 3188403..6e604c9 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -1587,6 +1587,7 @@ static int intel_init_ring_buffer(struct drm_device *dev, > ring->dev = dev; > INIT_LIST_HEAD(&ring->active_list); > INIT_LIST_HEAD(&ring->request_list); > + INIT_LIST_HEAD(&ring->execlist_queue); It's also a bit weird to now have sites where we initialize this list. or I'm missing something? -- Damien