From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Introduce FBC False Color for debug purposes.
Date: Mon, 4 Aug 2014 10:14:45 +0200 [thread overview]
Message-ID: <20140804081445.GM8727@phenom.ffwll.local> (raw)
In-Reply-To: <1406883885-6897-1-git-send-email-rodrigo.vivi@intel.com>
On Fri, Aug 01, 2014 at 02:04:45AM -0700, Rodrigo Vivi wrote:
> With this bit enabled, HW changes the color when compressing frames for
> debug purposes.
>
> ALthough the simple way to enable a single bit is over intel_reg_write,
> this value is overwriten on next update_fbc so depending on the workload
> it is not possible to set this bit with intel-gpu-tools. So this patch
> introduces a persistent way to enable false color over debugfs.
>
> v2: Use DEFINE_SIMPLE_ATTRIBUTE as Daniel suggested
> v3: (Ville) only do false color for IVB+ since according to spec bit is
> MBZ before IVB.
> v4: We don't have FBC on valleyview nor on cherryview (Ben)
> v5: s/!HAS_PCH_SPLIT/!HAS_FBC (Ville)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-08-04 8:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 16:26 [PATCH 1/2] drm/i915: Introduce FBC False Color for debug purposes Rodrigo Vivi
2014-07-30 16:26 ` [PATCH 2/2] drm/i915: FBC flush nuke for BDW Rodrigo Vivi
2014-07-31 19:07 ` [PATCH] " Rodrigo Vivi
2014-08-01 14:07 ` Ville Syrjälä
2014-08-04 8:11 ` Daniel Vetter
2014-08-04 10:51 ` Rodrigo Vivi
2014-08-07 20:04 ` Rodrigo Vivi
2014-08-08 7:06 ` Daniel Vetter
[not found] ` <CABVU7+tzGz9DaKiyg_KBegcrOWhXmHWD0xGjcaRpWHGyzRcjsA@mail.gmail.com>
[not found] ` <CAKMK7uH-PipHvNFNmgD4=_W=AhmcDVejf8MN6D9-17K4nLsDzw@mail.gmail.com>
2014-08-19 18:58 ` Daniel Vetter
2014-08-21 16:44 ` Rodrigo Vivi
2014-08-26 0:39 ` Rodrigo Vivi
2014-08-26 7:54 ` Daniel Vetter
2014-08-26 18:38 ` Rodrigo Vivi
2014-08-26 20:43 ` Daniel Vetter
2014-09-05 18:28 ` Paulo Zanoni
2014-09-05 19:35 ` Rodrigo Vivi
2014-09-05 21:12 ` Rodrigo Vivi
2014-09-08 7:29 ` Daniel Vetter
2014-09-08 7:26 ` Daniel Vetter
2014-07-31 4:01 ` [PATCH 1/2] drm/i915: Introduce FBC False Color for debug purposes Ben Widawsky
2014-07-31 19:07 ` [PATCH] " Rodrigo Vivi
2014-08-01 10:27 ` Ville Syrjälä
2014-08-01 9:04 ` Rodrigo Vivi
2014-08-04 8:14 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-20 13:46 Rodrigo Vivi
2014-07-07 14:59 ` Daniel Vetter
2014-07-07 18:42 ` Rodrigo Vivi
2014-07-28 13:04 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804081445.GM8727@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox