public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Pavel Popov <pavel.e.popov@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel-gpu-tools: Change type of variable from unsigned to uint64_t in gem_stress
Date: Mon, 4 Aug 2014 11:09:40 +0200	[thread overview]
Message-ID: <20140804090940.GU8727@phenom.ffwll.local> (raw)
In-Reply-To: <1406869844-6825-1-git-send-email-pavel.e.popov@intel.com>

On Fri, Aug 01, 2014 at 12:10:44PM +0700, Pavel Popov wrote:
> To run gem_stress with the correct number of buffers even if aperture size >= 4GB.
> 
> Signed-off-by: Pavel Popov <pavel.e.popov@intel.com>
> ---
>  tests/gem_stress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/gem_stress.c b/tests/gem_stress.c
> index 3bbe487..313a82a 100644
> --- a/tests/gem_stress.c
> +++ b/tests/gem_stress.c
> @@ -737,7 +737,7 @@ static int parse_options(int opt, int opt_index)
>  static void init(void)
>  {
>  	int i;
> -	unsigned tmp;
> +	uint64_t tmp;

We have tons of places which use gem_aperture_size. Have you reviewed them
all?
-Daniel

>  
>  	if (options.num_buffers == 0) {
>  		tmp = gem_aperture_size(drm_fd);
> -- 
> 1.9.1
> 
> 
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park, 
> 17 Krylatskaya Str., Bldg 4, Moscow 121614, 
> Russian Federation
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-08-04  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01  5:10 [PATCH] intel-gpu-tools: Change type of variable from unsigned to uint64_t in gem_stress Pavel Popov
2014-08-04  9:09 ` Daniel Vetter [this message]
2014-08-05 11:38   ` Popov, Pavel E
2014-08-05 12:27     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140804090940.GU8727@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=pavel.e.popov@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox