From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Tune down MCH_SSKPD values warning
Date: Mon, 4 Aug 2014 18:03:53 +0300 [thread overview]
Message-ID: <20140804150353.GH4193@intel.com> (raw)
In-Reply-To: <1407143908-19196-2-git-send-email-daniel.vetter@ffwll.ch>
On Mon, Aug 04, 2014 at 11:18:28AM +0200, Daniel Vetter wrote:
> Users often can't do anything about this since their vendors stopped
> providing BIOS updates. Also we seem to be able to hack around it
> with increased latency values, and thus far the only reports have
> been for screens with really high resolutions. So tune it down to a
> level where only developers can see it.
>
> Also drop some of the end-user fluff.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Both patches make sense to me so:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 4f879494e0c5..684dc5f60544 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5235,11 +5235,9 @@ static void gen6_check_mch_setup(struct drm_device *dev)
> uint32_t tmp;
>
> tmp = I915_READ(MCH_SSKPD);
> - if ((tmp & MCH_SSKPD_WM0_MASK) != MCH_SSKPD_WM0_VAL) {
> - DRM_INFO("Wrong MCH_SSKPD value: 0x%08x\n", tmp);
> - DRM_INFO("This can cause pipe underruns and display issues.\n");
> - DRM_INFO("Please upgrade your BIOS to fix this.\n");
> - }
> + if ((tmp & MCH_SSKPD_WM0_MASK) != MCH_SSKPD_WM0_VAL)
> + DRM_DEBUG_KMS("Wrong MCH_SSKPD value: 0x%08x This can cause underruns.\n",
> + tmp);
> }
>
> static void gen6_init_clock_gating(struct drm_device *dev)
> --
> 2.0.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-08-04 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 9:18 [PATCH 1/2] drm/i915: Tune done rc6 enabling output Daniel Vetter
2014-08-04 9:18 ` [PATCH 2/2] drm/i915: Tune down MCH_SSKPD values warning Daniel Vetter
2014-08-04 15:03 ` Ville Syrjälä [this message]
2014-08-04 15:10 ` Paulo Zanoni
2014-08-04 15:07 ` [PATCH 1/2] drm/i915: Tune done rc6 enabling output Paulo Zanoni
2014-08-04 15:34 ` Chris Wilson
2014-08-04 15:43 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804150353.GH4193@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox