From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Tune down MCH_SSKPD values warning Date: Mon, 4 Aug 2014 18:03:53 +0300 Message-ID: <20140804150353.GH4193@intel.com> References: <1407143908-19196-1-git-send-email-daniel.vetter@ffwll.ch> <1407143908-19196-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id D0E546E40E for ; Mon, 4 Aug 2014 08:04:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1407143908-19196-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 04, 2014 at 11:18:28AM +0200, Daniel Vetter wrote: > Users often can't do anything about this since their vendors stopped > providing BIOS updates. Also we seem to be able to hack around it > with increased latency values, and thus far the only reports have > been for screens with really high resolutions. So tune it down to a > level where only developers can see it. > = > Also drop some of the end-user fluff. > = > Signed-off-by: Daniel Vetter Both patches make sense to me so: Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_pm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel= _pm.c > index 4f879494e0c5..684dc5f60544 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5235,11 +5235,9 @@ static void gen6_check_mch_setup(struct drm_device= *dev) > uint32_t tmp; > = > tmp =3D I915_READ(MCH_SSKPD); > - if ((tmp & MCH_SSKPD_WM0_MASK) !=3D MCH_SSKPD_WM0_VAL) { > - DRM_INFO("Wrong MCH_SSKPD value: 0x%08x\n", tmp); > - DRM_INFO("This can cause pipe underruns and display issues.\n"); > - DRM_INFO("Please upgrade your BIOS to fix this.\n"); > - } > + if ((tmp & MCH_SSKPD_WM0_MASK) !=3D MCH_SSKPD_WM0_VAL) > + DRM_DEBUG_KMS("Wrong MCH_SSKPD value: 0x%08x This can cause underruns.= \n", > + tmp); > } > = > static void gen6_init_clock_gating(struct drm_device *dev) > -- = > 2.0.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC