From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/7] drm/i915/bdw: Always issue a force restore Date: Mon, 4 Aug 2014 18:20:00 -0700 Message-ID: <20140805012000.GC6052@intel.com> References: <1407176119-5294-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BEE4F6E08B for ; Mon, 4 Aug 2014 18:20:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1407176119-5294-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 04, 2014 at 11:15:13AM -0700, Rodrigo Vivi wrote: > From: Ben Widawsky > > The PDPs seem to get screwed up otherwise, specifically PDP0. I am not > really clear why this is required, it just works with full PPGTT. > > v2: Only do it for gen8, to limit regression potential > > v3: Fix the bugzilla links > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78891 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78935 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78936 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78937 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78938 > > Signed-off-by: Ben Widawsky > Signed-off-by: Rodrigo Vivi Hi Rodrigo. This patch was superseded by my [partially merged] series here: http://lists.freedesktop.org/archives/intel-gfx/2014-July/048311.html In that series I went through very thoroughly with design why we need to do this, and verified those patches do address this issue. So yeah, NAK from me - and please get those reworked or merged or whatever. Thanks [snip] -- Ben Widawsky, Intel Open Source Technology Center