From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 3/7] drm/i915/bdw: MI_FLUSH_DW a qword
	instead of dword
Date: Mon, 4 Aug 2014 18:21:01 -0700
Message-ID: <20140805012101.GD6052@intel.com>
References: <1407176119-5294-1-git-send-email-rodrigo.vivi@intel.com>
 <1407176119-5294-3-git-send-email-rodrigo.vivi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id EED7C89E5A
 for <intel-gfx@lists.freedesktop.org>; Mon,  4 Aug 2014 18:21:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1407176119-5294-3-git-send-email-rodrigo.vivi@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Aug 04, 2014 at 11:15:15AM -0700, Rodrigo Vivi wrote:
> From: Ben Widawsky <benjamin.widawsky@intel.com>
> 
> The actual post sync op is "Write Immediate Data QWord." It is therefore
> arguable that we should have always done a qword write.
> 
> The actual impetus for this patch is our decoder complains when we write
> a dword and I was trying to eliminate the spurious errors. With this
> patch, I've noticed a really strange reproducible error turns into a
> different strange reproducible error - so it does indeed have some
> effect of some sort.
> 
> This was also recommended to me by someone that is familiar with the
> Windows driver.
> 
> It's based on top of the semaphore series, so it won't be easily
> applied, I'd guess.
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Did we determine this was needed for anything other than shutting up the
instruction decoder, for debug? Seems like if the existing stuff ain't
broke, don't fix it.

[snip]


-- 
Ben Widawsky, Intel Open Source Technology Center