From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/6 v2] Add 180 degree primary and sprite rotation Date: Tue, 5 Aug 2014 15:35:48 +0200 Message-ID: <20140805133548.GK8727@phenom.ffwll.local> References: <1407218217-3437-1-git-send-email-sonika.jindal@intel.com> <20140805132542.GM4193@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 9748689C25 for ; Tue, 5 Aug 2014 06:35:37 -0700 (PDT) Received: by mail-wi0-f178.google.com with SMTP id hi2so1356386wib.11 for ; Tue, 05 Aug 2014 06:35:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140805132542.GM4193@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 05, 2014 at 04:25:42PM +0300, Ville Syrj=E4l=E4 wrote: > On Tue, Aug 05, 2014 at 11:26:51AM +0530, sonika.jindal@intel.com wrote: > > From: Sonika Jindal > > = > > This patchset provides support for 0/180 degree hardare rotaion for pri= mary and > > sprite planes. The rotation property is now made global and is part of > > drm_mode_config. It is attached to different planes. > > = > > v2: Moving the creation of property back to i915 (Ville) and resetting = property > > after disabling plane (Ville) > = > The series looks good to me. > = > For the patches not authored by me: > Reviewed-by: Ville Syrj=E4l=E4 > = > > = > > Sonika Jindal (3): > > drm: Add rotation_property to mode_config > > drm/i915: Add 180 degree primary plane rotation support > > drm: Resetting rotation property You've managed to cc exactly the wrong set of patches to dri-devel, namely the i915 specific ones. You should have cc'ed just the ones touching core drm (more if you feel like). Can you please fix that by resending? I've pulled them into dinq for now meanwhile. Thanks, Daniel > = > > Ville Syrj=E4l=E4 (3): > > drm/i915: Add 180 degree sprite rotation support > > drm/i915: Make intel_plane_restore() return an error > > drm/i915: Add rotation property for sprites > > = > > drivers/gpu/drm/drm_fb_helper.c | 9 ++- > > drivers/gpu/drm/i915/i915_reg.h | 4 ++ > > drivers/gpu/drm/i915/intel_display.c | 109 ++++++++++++++++++++++++++= ++++++-- > > drivers/gpu/drm/i915/intel_drv.h | 3 +- > > drivers/gpu/drm/i915/intel_pm.c | 6 ++ > > drivers/gpu/drm/i915/intel_sprite.c | 93 ++++++++++++++++++++++++++= --- > > include/drm/drm_crtc.h | 1 + > > 7 files changed, 211 insertions(+), 14 deletions(-) > > = > > -- = > > 1.7.10.4 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > -- = > Ville Syrj=E4l=E4 > Intel OTC > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch