From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 2/2] drm/i915/chv: Implement SSEU info for CHV Date: Tue, 5 Aug 2014 14:41:54 +0100 Message-ID: <20140805134154.GJ32279@strange.ger.corp.intel.com> References: <1406771987-1127-1-git-send-email-jeff.mcgee@intel.com> <1406771987-1127-2-git-send-email-jeff.mcgee@intel.com> <20140804082255.GQ8727@phenom.ffwll.local> <20140805134754.GC4660@jeffdesk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B1EF6E0C0 for ; Tue, 5 Aug 2014 06:42:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140805134754.GC4660@jeffdesk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Aug 05, 2014 at 08:47:54AM -0500, Jeff McGee wrote: > > > + > > > + /* Copy SSEU info to the const device info with pointer magic */ > > > + *(struct intel_sseu_info *)&dev_priv->info.sseu = sseu_info; > > > > I've thought gcc just does a memcpy for plain strut assignments, i.e. > > > > + dev_priv->info.sseu = sseu_info; That's what we have intel_device_info_runtime_init(), the SSEU init function should be called from there. -- Damien