From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 2/7] drm/i915: Add thread stall DOP clock gating workaround on Broadwell.
Date: Tue, 5 Aug 2014 20:10:28 +0300 [thread overview]
Message-ID: <20140805171028.GP4193@intel.com> (raw)
In-Reply-To: <1407176119-5294-2-git-send-email-rodrigo.vivi@intel.com>
On Mon, Aug 04, 2014 at 11:15:14AM -0700, Rodrigo Vivi wrote:
> From: Kenneth Graunke <kenneth@whitecape.org>
>
> Ben and I believe this will be necessary on production hardware.
>
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 684dc5f..f919596 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5412,6 +5412,10 @@ static void gen8_init_clock_gating(struct drm_device *dev)
> I915_WRITE(GEN8_ROW_CHICKEN,
> _MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));
>
> + /* WaDisableThreadStallDopClockGating:bdw */
> + I915_WRITE(GEN8_ROW_CHICKEN,
> + _MASKED_BIT_ENABLE(STALL_DOP_GATING_DISABLE));
It's already there just above.
> +
> /*
> * This GEN8_CENTROID_PIXEL_OPT_DIS W/A is only needed for
> * pre-production hardware
> --
> 1.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-08-05 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 18:15 [PATCH 1/7] drm/i915/bdw: Always issue a force restore Rodrigo Vivi
2014-08-04 18:15 ` [PATCH 2/7] drm/i915: Add thread stall DOP clock gating workaround on Broadwell Rodrigo Vivi
2014-08-05 17:10 ` Ville Syrjälä [this message]
2014-08-04 18:15 ` [PATCH 3/7] drm/i915/bdw: MI_FLUSH_DW a qword instead of dword Rodrigo Vivi
2014-08-05 1:21 ` Ben Widawsky
2014-08-04 18:15 ` [PATCH 4/7] drm/i915/bdw: cs-stall before state cache invld w/a Rodrigo Vivi
2014-08-05 12:39 ` Ville Syrjälä
2014-08-04 18:15 ` [PATCH 5/7] drm/i915: avoid emiting semaphore wait on GEN8 when seqno wrap happened Rodrigo Vivi
2014-08-05 8:36 ` Daniel Vetter
2014-08-04 18:15 ` [PATCH 6/7] drm/i915: BDW Semaphore signal with Post Sync Rodrigo Vivi
2014-08-04 18:15 ` [PATCH 7/7] Revert "drm/i915: Enable semaphores on BDW" Rodrigo Vivi
2014-08-07 20:05 ` Rodrigo Vivi
2014-08-08 7:10 ` Daniel Vetter
2014-08-08 7:13 ` Daniel Vetter
2014-08-08 7:31 ` Chris Wilson
2014-08-05 1:20 ` [PATCH 1/7] drm/i915/bdw: Always issue a force restore Ben Widawsky
2014-08-05 8:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805171028.GP4193@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox