From: Daniel Vetter <daniel@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: lock around link status and link training.
Date: Wed, 6 Aug 2014 00:07:32 +0200 [thread overview]
Message-ID: <20140805220732.GN8727@phenom.ffwll.local> (raw)
In-Reply-To: <1407199220-10984-1-git-send-email-airlied@gmail.com>
On Tue, Aug 5, 2014 at 2:40 AM, Dave Airlie <airlied@gmail.com> wrote:
> @@ -3502,10 +3505,13 @@ go_again:
> void
> intel_dp_check_link_status(struct intel_dp *intel_dp)
> {
> + struct drm_device *dev = intel_dp_to_dev(intel_dp);
> struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
> u8 sink_irq_vector;
> u8 link_status[DP_LINK_STATUS_SIZE];
>
> + WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
> +
> /* FIXME: This access isn't protected by any locks. */
If you drop the FIXME here (since this patch address it) this is
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I guess you'll pick this up directly to drm-next like that other mst
fixes?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-08-05 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 0:40 [PATCH] drm/i915: lock around link status and link training Dave Airlie
2014-08-05 22:07 ` Daniel Vetter [this message]
2014-08-05 23:59 ` Dave Airlie
2014-08-06 0:12 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805220732.GN8727@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox