From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: lock around link status and link
 training.
Date: Wed, 6 Aug 2014 00:07:32 +0200
Message-ID: <20140805220732.GN8727@phenom.ffwll.local>
References: <1407199220-10984-1-git-send-email-airlied@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by gabe.freedesktop.org (Postfix) with ESMTP id 454B26E521
 for <intel-gfx@lists.freedesktop.org>; Tue,  5 Aug 2014 15:07:20 -0700 (PDT)
Received: by mail-wg0-f51.google.com with SMTP id b13so1691887wgh.34
 for <intel-gfx@lists.freedesktop.org>; Tue, 05 Aug 2014 15:07:19 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1407199220-10984-1-git-send-email-airlied@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 5, 2014 at 2:40 AM, Dave Airlie <airlied@gmail.com> wrote:
> @@ -3502,10 +3505,13 @@ go_again:
>  void
>  intel_dp_check_link_status(struct intel_dp *intel_dp)
>  {
> +       struct drm_device *dev = intel_dp_to_dev(intel_dp);
>         struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
>         u8 sink_irq_vector;
>         u8 link_status[DP_LINK_STATUS_SIZE];
>
> +       WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
> +
>         /* FIXME: This access isn't protected by any locks. */

If you drop the FIXME here (since this patch address it) this is

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I guess you'll pick this up directly to drm-next like that other mst
fixes?
-Daniel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch