From: Daniel Vetter <daniel@ffwll.ch>
To: sonika.jindal@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/6] drm: Resetting rotation property
Date: Wed, 6 Aug 2014 09:55:08 +0200 [thread overview]
Message-ID: <20140806075508.GP8727@phenom.ffwll.local> (raw)
In-Reply-To: <1407299127-1453-7-git-send-email-sonika.jindal@intel.com>
On Wed, Aug 06, 2014 at 09:55:27AM +0530, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
>
> Reset rotation property to 0.
>
> v2: Resetting after disabling the plane
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Still missing a cc: dri-devel here. And please don't resend the entire
series again, just this patch to dri-devel. The patches are merged
already, but we must follow proper procedures for getting core drm patches
in.
Thanks, Daniel
> ---
> drivers/gpu/drm/drm_fb_helper.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 3144db9..d139edd 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -345,10 +345,17 @@ static bool restore_fbdev_mode(struct drm_fb_helper *fb_helper)
>
> drm_warn_on_modeset_not_all_locked(dev);
>
> - list_for_each_entry(plane, &dev->mode_config.plane_list, head)
> + list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
> if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> drm_plane_force_disable(plane);
>
> + if (dev->mode_config.rotation_property) {
> + drm_object_property_set_value(&plane->base,
> + dev->mode_config.rotation_property,
> + BIT(DRM_ROTATE_0));
> + }
> + }
> +
> for (i = 0; i < fb_helper->crtc_count; i++) {
> struct drm_mode_set *mode_set = &fb_helper->crtc_info[i].mode_set;
> struct drm_crtc *crtc = mode_set->crtc;
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-08-06 7:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 4:25 [PATCH 0/6 v2] Add 180 degree primary and sprite rotation sonika.jindal
2014-08-06 4:25 ` [PATCH 1/6] drm/i915: Add 180 degree sprite rotation support sonika.jindal
2014-08-06 4:25 ` [PATCH 2/6] drm/i915: Make intel_plane_restore() return an error sonika.jindal
2014-08-06 4:25 ` [PATCH 3/6] drm: Add rotation_property to mode_config sonika.jindal
2014-08-06 4:25 ` [PATCH 4/6] drm/i915: Add rotation property for sprites sonika.jindal
2014-08-06 4:25 ` [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support sonika.jindal
2014-08-06 4:25 ` [PATCH 6/6] drm: Resetting rotation property sonika.jindal
2014-08-06 7:55 ` Daniel Vetter [this message]
2014-08-06 7:56 ` sonika.jindal
2014-08-06 8:40 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2014-08-05 5:56 [PATCH 0/6 v2] Add 180 degree primary and sprite rotation sonika.jindal
2014-08-05 5:56 ` [PATCH 6/6] drm: Resetting rotation property sonika.jindal
2014-07-15 8:40 [PATCH 0/6] Add 180 degree primary and sprite rotation sonika.jindal
2014-07-15 8:40 ` [PATCH 6/6] drm: Resetting rotation property sonika.jindal
2014-08-04 12:01 ` Ville Syrjälä
2014-08-04 12:03 ` Jindal, Sonika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806075508.GP8727@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox