From: Jeff McGee <jeff.mcgee@intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/chv: Implement SSEU info for CHV
Date: Wed, 6 Aug 2014 09:40:30 -0500 [thread overview]
Message-ID: <20140806144030.GE4660@jeffdesk> (raw)
In-Reply-To: <20140805134154.GJ32279@strange.ger.corp.intel.com>
On Tue, Aug 05, 2014 at 02:41:54PM +0100, Damien Lespiau wrote:
> On Tue, Aug 05, 2014 at 08:47:54AM -0500, Jeff McGee wrote:
> > > > +
> > > > + /* Copy SSEU info to the const device info with pointer magic */
> > > > + *(struct intel_sseu_info *)&dev_priv->info.sseu = sseu_info;
> > >
> > > I've thought gcc just does a memcpy for plain strut assignments, i.e.
> > >
> > > + dev_priv->info.sseu = sseu_info;
>
> That's what we have intel_device_info_runtime_init(), the SSEU init
> function should be called from there.
>
> --
> Damien
Agree. I will move the call to intel_device_info_runtime_init().
-Jeff
next prev parent reply other threads:[~2014-08-06 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 1:59 [PATCH 1/2] drm/i915: Slice/Subslice/EU info via GETPARAM jeff.mcgee
2014-07-31 1:59 ` [PATCH 2/2] drm/i915/chv: Implement SSEU info for CHV jeff.mcgee
2014-07-31 11:55 ` Mcaulay, Alistair
2014-07-31 23:18 ` Jeff McGee
2014-08-04 8:18 ` Daniel Vetter
2014-08-04 8:22 ` Daniel Vetter
2014-08-05 13:47 ` Jeff McGee
2014-08-05 13:41 ` Damien Lespiau
2014-08-06 14:40 ` Jeff McGee [this message]
2014-07-31 11:53 ` [PATCH 1/2] drm/i915: Slice/Subslice/EU info via GETPARAM Mcaulay, Alistair
2014-07-31 23:16 ` Jeff McGee
2014-08-04 8:20 ` Daniel Vetter
2014-08-05 14:03 ` Jeff McGee
2014-08-05 14:50 ` Daniel Vetter
2014-08-06 14:43 ` Jeff McGee
2014-08-06 15:02 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806144030.GE4660@jeffdesk \
--to=jeff.mcgee@intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox