From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff McGee <jeff.mcgee@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/chv: Implement SSEU info for
	CHV
Date: Wed, 6 Aug 2014 09:40:30 -0500
Message-ID: <20140806144030.GE4660@jeffdesk>
References: <1406771987-1127-1-git-send-email-jeff.mcgee@intel.com>
 <1406771987-1127-2-git-send-email-jeff.mcgee@intel.com>
 <20140804082255.GQ8727@phenom.ffwll.local>
 <20140805134754.GC4660@jeffdesk>
 <20140805134154.GJ32279@strange.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by gabe.freedesktop.org (Postfix) with ESMTP id 708EA6E5C0
 for <intel-gfx@lists.freedesktop.org>; Wed,  6 Aug 2014 07:29:50 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140805134154.GJ32279@strange.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Aug 05, 2014 at 02:41:54PM +0100, Damien Lespiau wrote:
> On Tue, Aug 05, 2014 at 08:47:54AM -0500, Jeff McGee wrote:
> > > > +
> > > > +	/* Copy SSEU info to the const device info with pointer magic */
> > > > +	*(struct intel_sseu_info *)&dev_priv->info.sseu = sseu_info;
> > > 
> > > I've thought gcc just does a memcpy for plain strut assignments, i.e.
> > > 
> > > +	dev_priv->info.sseu = sseu_info;
> 
> That's what we have intel_device_info_runtime_init(), the SSEU init
> function should be called from there.
> 
> -- 
> Damien

Agree. I will move the call to intel_device_info_runtime_init().
-Jeff