From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/i915: Remove an unreachable 'return'
Date: Mon, 11 Aug 2014 12:47:52 +0300 [thread overview]
Message-ID: <20140811094752.GK4193@intel.com> (raw)
In-Reply-To: <1407621658-8222-2-git-send-email-damien.lespiau@intel.com>
On Sat, Aug 09, 2014 at 11:00:57PM +0100, Damien Lespiau wrote:
> Running smatch adds quite a few checks to what sparse is doing. This is
> one of them.
>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 4b89447..a6af1b2 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8646,7 +8646,6 @@ void intel_release_load_detect_pipe(struct drm_connector *connector,
> }
>
> goto unlock;
> - return;
I have a locking fix that removes the goto and keeps the return :)
I'll send it out now.
> }
>
> /* Switch crtc and encoder back off if necessary */
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-08-11 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 22:00 [PATCH 1/3] drm/i915: Make intel_disable_shared_dpll() static Damien Lespiau
2014-08-09 22:00 ` [PATCH 2/3] drm/i915: Remove an unreachable 'return' Damien Lespiau
2014-08-11 9:47 ` Ville Syrjälä [this message]
2014-08-09 22:00 ` [PATCH 3/3] drm/i915: Remove set but unused 'gt_perf_status' Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811094752.GK4193@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox