From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 26/43] drm/i915/bdw: Always use MMIO flips with Execlists Date: Mon, 11 Aug 2014 22:34:28 +0200 Message-ID: <20140811203428.GX10500@phenom.ffwll.local> References: <1406217891-8912-1-git-send-email-thomas.daniel@intel.com> <1406217891-8912-27-git-send-email-thomas.daniel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 462D16E321 for ; Mon, 11 Aug 2014 13:34:17 -0700 (PDT) Received: by mail-wi0-f170.google.com with SMTP id f8so6105257wiw.3 for ; Mon, 11 Aug 2014 13:34:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1406217891-8912-27-git-send-email-thomas.daniel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thomas Daniel Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Jul 24, 2014 at 05:04:34PM +0100, Thomas Daniel wrote: > From: Oscar Mateo > > The normal flip function places things in the ring in the legacy > way, so we either fix that or force MMIO flips always as we do in > this patch. > > Signed-off-by: Oscar Mateo > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > drivers/gpu/drm/i915/intel_lrc.c | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 5ed6a1a..8129af4 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -9482,6 +9482,8 @@ static bool use_mmio_flip(struct intel_engine_cs *ring, > return false; > else if (i915.use_mmio_flip > 0) > return true; > + else if (i915.enable_execlists) > + return true; > else > return ring != obj->ring; > } > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c > index cd834b3..0a04c03 100644 > --- a/drivers/gpu/drm/i915/intel_lrc.c > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -83,7 +83,8 @@ int intel_sanitize_enable_execlists(struct drm_device *dev, int enable_execlists > if (enable_execlists == 0) > return 0; > > - if (HAS_LOGICAL_RING_CONTEXTS(dev) && USES_PPGTT(dev)) > + if (HAS_LOGICAL_RING_CONTEXTS(dev) && USES_PPGTT(dev) && > + i915.use_mmio_flip >= 0) Almost every patch gets the alignment wrong somewhere. Not terribly amused. -Daniel > return 1; > > return 0; > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch