public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915/bdw: BDW Software Turbo
Date: Thu, 14 Aug 2014 12:37:53 -0700	[thread overview]
Message-ID: <20140814123753.59fc9e63@jbarnes-desktop> (raw)
In-Reply-To: <20140811213357.GH10500@phenom.ffwll.local>

On Mon, 11 Aug 2014 23:33:57 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Mon, Aug 11, 2014 at 11:08:38AM -0700, Daisy Sun wrote:
> > BDW supports GT C0 residency reporting in constant time unit. Driver
> > calculates GT utilization based on C0 residency and adjusts RP
> > frequency up/down accordingly. For offscreen workload specificly,
> > set frequency to RP0.
> > 
> > Offscreen task is not restricted by frame rate, it can be
> > executed as soon as possible. Transcoding and serilized workload
> > between CPU and GPU both need high GT performance, RP0 is a good
> > option in this case. RC6 will kick in to compensate power
> > consumption when GT is not active.
> > 
> > v2: Rebase on recent drm-intel-nightly
> > v3: Add flip timerout monitor, when no flip is deteced within
> > 100ms, set frequency to RP0.
> 
> Ok, let's make this really clear:
> 
> If you wire this into the flip handling in any way, I will not merge your
> patch. The timer should be fully independant and tie into the gpu
> busy/idle handling we already have.

Sounds like Daisy won't be able to spend any more time on this either.

So we're left with this patch, which does improve things for most
cases, or no patch, which leaves things universally bad.

Unless someone wants to pick up the additional work and testing of
using a timer scheme, making sure we don't have needless wakeups, and
generally improve power/perf across even more cases than this patch.

-- 
Jesse Barnes, Intel Open Source Technology Center

  parent reply	other threads:[~2014-08-14 19:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 18:08 [PATCH v3] drm/i915/bdw: BDW Software Turbo Daisy Sun
2014-08-11 21:33 ` Daniel Vetter
2014-08-11 22:13   ` Sun, Daisy
2014-08-14 19:37   ` Jesse Barnes [this message]
2014-08-27 18:57     ` Daniel Vetter
2014-08-28  9:10       ` Chris Wilson
2014-09-04 20:59         ` Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140814123753.59fc9e63@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox