From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/5] drm/i915: Print captured bo for all VM
 in error state
Date: Thu, 14 Aug 2014 17:03:40 +0200
Message-ID: <20140814150340.GU10500@phenom.ffwll.local>
References: <1407870351-6064-1-git-send-email-chris@chris-wilson.co.uk>
 <87lhqs1m0x.fsf@gaia.fi.intel.com>
 <20140814065045.GJ10052@nuc-i3427.alporthouse.com>
 <87sikzxtkp.fsf@gaia.fi.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f176.google.com (mail-we0-f176.google.com
 [74.125.82.176])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4EE3E6E6CA
 for <intel-gfx@lists.freedesktop.org>; Thu, 14 Aug 2014 08:03:35 -0700 (PDT)
Received: by mail-we0-f176.google.com with SMTP id q58so1217120wes.7
 for <intel-gfx@lists.freedesktop.org>; Thu, 14 Aug 2014 08:03:30 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87sikzxtkp.fsf@gaia.fi.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Aug 14, 2014 at 01:18:46PM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > On Wed, Aug 13, 2014 at 05:50:38PM +0300, Mika Kuoppala wrote:
> >> Chris Wilson <chris@chris-wilson.co.uk> writes:
> >> 
> >> > The current error state harks back to the era of just a single VM. For
> >> > full-ppgtt, we capture every bo on every VM. It behoves us to then print
> >> > every bo for every VM, which we currently fail to do and so miss vital
> >> > information in the error state.
> >> >
> >> > v2: Use the vma address rather than -1!
> >> >
> >> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >> 
> >> Offsets can collide between different vm areas.
> >> 
> >> If we add vm index also to the captured batchbuffer objects,
> >> we could print it part of the offset '%d:0x%x' that would easily
> >> identify vm and we would immediately see what vm was active on a ring.
> >
> > The offsets are printed out per-vm. You want to be more specific in your
> > complaint. Based on earlier discussion, I think you just want to know
> > the guilty vm.
> > -Chris
> 
> Yes. And it can be done as a follow up too.
> 
> 1/5:
> Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch