Re: [PATCH 14/16] Revert "drm/i915: Nuke pipe A quirk on i830M"

Thomas Richter
2014-08-15T13:36:20Z

On 15.08.2014 00:22, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> 830 really does want the pipe A quirk. The planes and ports don't
> react to any register writes unless the pipe currently attached
> to them is running, so it's impossible to move them to the other
> pipe unless both pipes are running.
>
> Also it's documented that the DPLL must be enabled on both pipes
> whenever it's needed.
>
> This reverts commit ac6696d3236bd61503f89a1a99680fd7894d5d53.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Works on both the R31 and the S6010.

Reviewed-by: Thomas Richter <richter@rus.uni-stuttgart.de>

> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 6462bcf..e1c0c0b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12503,6 +12503,9 @@ static struct intel_quirk intel_quirks[] = {
> /* ThinkPad T60 needs pipe A force quirk (bug #16494) */
> { 0x2782, 0x17aa, 0x201a, quirk_pipea_force },
>
> + /* 830 needs to leave pipe A & dpll A up */
> + { 0x3577, PCI_ANY_ID, PCI_ANY_ID, quirk_pipea_force },
> +
> /* Lenovo U160 cannot use SSC on LVDS */
> { 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },