Re: [PATCH 09/16] drm/i915: Kill useless ns2501_dump_regs

Thomas Richter
2014-08-15T13:08:32Z

On 15.08.2014 00:22, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>

Looks perfectly fine to me.

Signed-off-by: Thomas Richter <richter@rus.uni-stuttgart.de>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/dvo_ns2501.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo_ns2501.c b/drivers/gpu/drm/i915/dvo_ns2501.c
> index 74f2af7..85030d4 100644
> --- a/drivers/gpu/drm/i915/dvo_ns2501.c
> +++ b/drivers/gpu/drm/i915/dvo_ns2501.c
> @@ -479,22 +479,6 @@ static void ns2501_dpms(struct intel_dvo_device *dvo, bool enable)
> }
> }
>
> -static void ns2501_dump_regs(struct intel_dvo_device *dvo)
> -{
> - uint8_t val;
> -
> - ns2501_readb(dvo, NS2501_FREQ_LO, &val);
> - DRM_DEBUG_KMS("NS2501_FREQ_LO: 0x%02x\n", val);
> - ns2501_readb(dvo, NS2501_FREQ_HI, &val);
> - DRM_DEBUG_KMS("NS2501_FREQ_HI: 0x%02x\n", val);
> - ns2501_readb(dvo, NS2501_REG8, &val);
> - DRM_DEBUG_KMS("NS2501_REG8: 0x%02x\n", val);
> - ns2501_readb(dvo, NS2501_REG9, &val);
> - DRM_DEBUG_KMS("NS2501_REG9: 0x%02x\n", val);
> - ns2501_readb(dvo, NS2501_REGC, &val);
> - DRM_DEBUG_KMS("NS2501_REGC: 0x%02x\n", val);
> -}
> -
> static void ns2501_destroy(struct intel_dvo_device *dvo)
> {
> struct ns2501_priv *ns = dvo->dev_priv;
> @@ -512,6 +496,5 @@ struct intel_dvo_dev_ops ns2501_ops = {
> .mode_set = ns2501_mode_set,
> .dpms = ns2501_dpms,
> .get_hw_state = ns2501_get_hw_state,
> - .dump_regs = ns2501_dump_regs,
> .destroy = ns2501_destroy,
> };