From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915/bdw: Apply workarounds using
 the golden render state
Date: Wed, 20 Aug 2014 17:52:54 +0300
Message-ID: <20140820145254.GI4193@intel.com>
References: <1408544358-26735-1-git-send-email-arun.siluvery@linux.intel.com>
 <1408544358-26735-2-git-send-email-arun.siluvery@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1BEC86E1CA
 for <intel-gfx@lists.freedesktop.org>; Wed, 20 Aug 2014 07:53:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1408544358-26735-2-git-send-email-arun.siluvery@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Arun Siluvery <arun.siluvery@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Aug 20, 2014 at 03:19:17PM +0100, Arun Siluvery wrote:
> Workarounds for bdw are currently applied in init_clock_gating() but they
> are lost following a gpu reset. Some of the WA registers are part of regi=
ster
> state context and they are restored with every context switch so initiali=
zing
> them in golden render state ensures that they are applied even when we st=
art
> with an uninitialized context or during hw initlialization followed by a =
reset.
> =

> v2: Add comments corresponding to WAs in golden render state (Chris).
> =

> The generation of render state is not a straighforward process, it would
> be ideal to augment WA values from during the setup state as opposed to
> using a tool but that would be a follow up patch.

I'd still prefer just emitting the LRIs from code rather tha mucking
about with null batch. Less hoops to jump through when adding a new w/a.

-- =

Ville Syrj=E4l=E4
Intel OTC