From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: fix panel unlock register mask
Date: Thu, 21 Aug 2014 16:39:00 +0300 [thread overview]
Message-ID: <20140821133859.GN4193@intel.com> (raw)
In-Reply-To: <1408622786-19318-1-git-send-email-jani.nikula@intel.com>
On Thu, Aug 21, 2014 at 03:06:25PM +0300, Jani Nikula wrote:
> Use the correct mask for the unlock bits. In theory this could have lead
> to incorrect asserts but this is unlikely in practise.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 0b327ebb2d9e..fe1d00dc9ef5 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1208,7 +1208,7 @@ static void assert_panel_unlocked(struct drm_i915_private *dev_priv,
>
> val = I915_READ(pp_reg);
> if (!(val & PANEL_POWER_ON) ||
> - ((val & PANEL_UNLOCK_REGS) == PANEL_UNLOCK_REGS))
> + ((val & PANEL_UNLOCK_MASK) == PANEL_UNLOCK_REGS))
> locked = false;
>
> if (I915_READ(lvds_reg) & LVDS_PIPEB_SELECT)
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2014-08-21 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 12:06 [PATCH 1/2] drm/i915: fix panel unlock register mask Jani Nikula
2014-08-21 12:06 ` [PATCH 2/2] drm/i915: improve assert_panel_unlocked Jani Nikula
2014-08-21 14:56 ` Ville Syrjälä
2014-08-21 15:01 ` Paulo Zanoni
2014-08-22 8:00 ` Ville Syrjälä
2014-08-26 14:38 ` Daniel Vetter
2014-08-22 12:04 ` [PATCH v2 " Jani Nikula
2014-08-21 13:36 ` [PATCH 1/2] drm/i915: fix panel unlock register mask Paulo Zanoni
2014-08-21 13:39 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821133859.GN4193@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox