From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
"Mcaulay, Alistair" <alistair.mcaulay@intel.com>,
"Daniel, Thomas" <thomas.daniel@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3] drm/i915: Rework GPU reset sequence to match driver load & thaw
Date: Mon, 25 Aug 2014 22:18:09 +0200 [thread overview]
Message-ID: <20140825201809.GI15520@phenom.ffwll.local> (raw)
In-Reply-To: <20140820155641.GF12830@nuc-i3427.alporthouse.com>
On Wed, Aug 20, 2014 at 04:56:41PM +0100, Chris Wilson wrote:
> On Wed, Aug 20, 2014 at 03:21:55PM +0000, Mcaulay, Alistair wrote:
> > It is not the same. This is a special case when re-initialising the hw. This flag is to allow gem_init_hw() to complete successfully during reset.
> > At any other point during reset, -EAGAIN should be returned.
>
> Indeed. You've missed the point. Look closer at the reset counter and
> reset ordering.
We could try to mark the gpu as reset again before starting the reinit to
avoid this kludge. But that has the problem that if the ring init fails we
have a bit a mess in marking the gpu terminally wedged. So I think overall
not prettier than what we have here ... And if I'm mistaken I guess I can
put on my idiot hat and merge the fixup ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-08-25 20:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 15:05 [PATCH] drm/i915: Rework GPU reset sequence to match driver load & thaw alistair.mcaulay
2014-07-26 1:05 ` Ben Widawsky
2014-07-28 9:26 ` Daniel Vetter
2014-07-28 17:12 ` Mcaulay, Alistair
2014-07-29 0:16 ` Ben Widawsky
2014-07-29 17:25 ` Mcaulay, Alistair
2014-07-29 18:12 ` Daniel Vetter
2014-07-29 7:36 ` Chris Wilson
2014-07-29 10:32 ` Daniel Vetter
2014-07-30 16:59 ` Mcaulay, Alistair
2014-07-30 21:00 ` Daniel Vetter
2014-07-31 16:37 ` Mcaulay, Alistair
2014-08-04 7:52 ` Daniel Vetter
2014-08-05 8:47 ` [PATCH v2] " alistair.mcaulay
2014-08-06 12:58 ` Mcaulay, Alistair
2014-08-06 16:24 ` Mika Kuoppala
2014-08-15 13:33 ` Mcaulay, Alistair
2014-08-15 15:41 ` Daniel Vetter
2014-08-15 17:03 ` Mika Kuoppala
2014-08-15 17:51 ` [PATCH v3] " alistair.mcaulay
2014-08-19 10:12 ` Mcaulay, Alistair
2014-08-19 12:35 ` Mika Kuoppala
2014-08-21 12:38 ` Mcaulay, Alistair
2014-08-25 20:28 ` Daniel Vetter
2014-08-20 14:46 ` Daniel, Thomas
2014-08-20 14:58 ` Chris Wilson
2014-08-20 15:21 ` Mcaulay, Alistair
2014-08-20 15:56 ` Chris Wilson
2014-08-25 20:18 ` Daniel Vetter [this message]
2014-08-26 6:09 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825201809.GI15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alistair.mcaulay@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.daniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox