From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/bdw: Render moot context reset and
 switch with Execlists
Date: Mon, 25 Aug 2014 22:39:39 +0200
Message-ID: <20140825203939.GK15520@phenom.ffwll.local>
References: <1406217891-8912-12-git-send-email-thomas.daniel@intel.com>
 <1408548564-3787-1-git-send-email-thomas.daniel@intel.com>
 <20140820153605.GE12830@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by gabe.freedesktop.org (Postfix) with ESMTP id 611C36E234
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Aug 2014 13:39:17 -0700 (PDT)
Received: by mail-wg0-f43.google.com with SMTP id l18so13653808wgh.14
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Aug 2014 13:39:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140820153605.GE12830@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Thomas Daniel <thomas.daniel@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote:
> On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote:
> > These two functions make no sense in an Logical Ring Context & Execlists
> > world.
> > 
> > v2: We got rid of lrc_enabled and centralized everything in the sanitized
> > i915.enable_execlists instead.
> > 
> > Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> > 
> > v3: Rebased.  Corrected a typo in comment for i915_switch_context and
> > added a comment that it should not be called in execlist mode. Added
> > WARN_ON if i915_switch_context is called in execlist mode. Moved check
> > for execlist mode out of i915_switch_context and into callers. Added
> > comment in context_reset explaining why nothing is done in execlist
> > mode.
> 
> No, this is not the way. The requirement is to reduce the number of
> special cases not increase them. These should be evaluated to be no-ops
> when execlists is used.

I think it's ok-ish for now. Maybe we need to reconsider when we wire up
lrc reclaim - which is the real user of the switch_context in gpu_idle.
The problem I have though is that I can't parse the subject of the patch,
someone please translate that to simplified English for me. I can do the
replacement while applying.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch