From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 35/43] drm/i915/bdw: Make sure error capture keeps working with Execlists Date: Mon, 25 Aug 2014 23:00:39 +0200 Message-ID: <20140825210039.GO15520@phenom.ffwll.local> References: <1406217891-8912-1-git-send-email-thomas.daniel@intel.com> <1406217891-8912-36-git-send-email-thomas.daniel@intel.com> <20140815121425.GR10500@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by gabe.freedesktop.org (Postfix) with ESMTP id C245A89873 for ; Mon, 25 Aug 2014 14:00:19 -0700 (PDT) Received: by mail-wg0-f48.google.com with SMTP id x13so13585673wgg.19 for ; Mon, 25 Aug 2014 14:00:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Daniel, Thomas" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Thu, Aug 21, 2014 at 10:57:09AM +0000, Daniel, Thomas wrote: > > > > -----Original Message----- > > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Friday, August 15, 2014 1:14 PM > > To: Daniel, Thomas > > Cc: intel-gfx@lists.freedesktop.org; Mika Kuoppala > > Subject: Re: [Intel-gfx] [PATCH 35/43] drm/i915/bdw: Make sure error > > capture keeps working with Execlists > > > > On Thu, Jul 24, 2014 at 05:04:43PM +0100, Thomas Daniel wrote: > > > From: Oscar Mateo > > > > > > Since the ringbuffer does not belong per engine anymore, we have to > > > make sure that we are always recording the correct ringbuffer. > > > > > > TODO: This is only a small fix to keep basic error capture working, > > > but we need to add more information for it to be useful (e.g. dump the > > > context being executed). > > > > > > v2: Reorder how the ringbuffer is chosen to clarify the change and > > > rename the variable, both changes suggested by Chris Wilson. Also, add > > > the TODO comment to the code, as suggested by Daniel. > > > > > > Signed-off-by: Oscar Mateo > > > > There's a bit too much stuff in-flight to fix up error capture for ppgtt. > > I think it's better to stall this patch here until that work is completed. > > Please coordinate with Mika here. > > -Daniel > Mika has now closed the Jira issue. This patch still applies and looks > correct. Is it OK to be merged as-is? Apparently Mika closed the Jira before I've merged all the patches. I'd like to do that first, then come back to this patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch