From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Dave Gordon <david.s.gordon@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915/bdw: Map unused PDPs to a scratch page
Date: Tue, 26 Aug 2014 10:05:40 +0200 [thread overview]
Message-ID: <20140826080540.GD15520@phenom.ffwll.local> (raw)
In-Reply-To: <1408383330-21935-5-git-send-email-rodrigo.vivi@intel.com>
On Mon, Aug 18, 2014 at 10:35:30AM -0700, Rodrigo Vivi wrote:
> From: Bob Beckett <robert.beckett@intel.com>
>
> Create a scratch page for the two unused PDPs and set all the PTEs
> for them to point to it.
>
> This patch addresses a page fault, and subsequent hang in pipe
> control flush. In these cases, the Main Graphic Arbiter Error
> register [0x40A0] showed a TLB Page Fault error, and a high memory
> address (higher than the size of our PPGTT) was reported in the
> Fault TLB RD Data0 register (0x4B10).
>
> PDP2 & PDP3 were not set because, in theory, they aren't required
> for our PPGTT size, but they should be mapped to a scratch page
> anyway.
>
> v2: Rebase on latest nightly.
>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com> (v1)
> Signed-off-by: Dave Gordon <david.s.gordon@intel.com> (v2)
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
No idea about this one, especially since there's tons of other bdw ppgtt
patches in-flight. I've merged all the others though.
Aside: We need to figure out how to make people review their -collector
assignments actually, it seems to totally not work :(
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-08-26 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 17:35 [PATCH 0/4] drm-intel-collector - update Rodrigo Vivi
2014-08-18 17:35 ` [PATCH 1/4] drm/i915: Bring UP Power Wells before disabling RC6 Rodrigo Vivi
2014-08-18 17:35 ` [PATCH 2/4] drm/i915: Don't save/restore RS when not used Rodrigo Vivi
2014-08-18 17:35 ` [PATCH 3/4] drm/i915: honour forced connector modes Rodrigo Vivi
2014-08-18 17:35 ` [PATCH 4/4] drm/i915/bdw: Map unused PDPs to a scratch page Rodrigo Vivi
2014-08-26 8:05 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826080540.GD15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox