Re: [PATCH 00/14] drm/i915: edp vdd locking and prep for power sequencer kick

Daniel Vetter
2014-08-26T09:35:05Z

On Tue, Aug 19, 2014 at 01:46:58PM +0300, Ville Syrjälä wrote:
> On Tue, Aug 19, 2014 at 11:08:33AM +0300, Jani Nikula wrote:
> > On Mon, 18 Aug 2014, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > While wrestling with the VLV/CHV panel power sequencer I noticed the locking
> > > in our edp vdd code was rather broken. This series aims to fix that by
> > > introducing a power seqeuencer mutex. I was already thinking about using the
> > > aux.hw_mutex for this since it's already locked around the aux ->transfer()
> > > function, but the VLV/CHV multiple power sequencer issue requires a single
> > > lock instead of per-port.
> >
> > For extra kicks, see i915_save_display() and i915_restore_display(). Why
> > are we doing this to ourselves?
>
> Yeah, crap all around. I suppose someone needs to frob the lvds code
> a bit before we can kill the power sequencer stuff from those two
> functions.

I think with Jani's reworked backlight code we can ditch most of them for
kms. For the panel power sequencer I guess we just need to hook up a
->reset function to lvds/edp.

That would also have the benefit of us being able to ditch the lvds
restore crap.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch